master<-dev#1445
Merged
Merged
Conversation
* Filter non-gRPC paths from metrics labels to prevent cardinality explosion Bot/scanner requests with arbitrary paths (e.g. /$(pwd)/netlify.toml) were being recorded as-is in the method label, polluting Grafana dashboards and risking unbounded label cardinality in Prometheus. Only valid gRPC prefixes are now recorded; all other paths are bucketed under "unknown". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Normalize gRPC method labels into fixed buckets to prevent cardinality explosion Instead of storing raw request paths as metric labels, map each known gRPC prefix to a constant bucket name (trainlcd, grpc_health, grpc_reflection) and validate the method token contains only safe characters before appending it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.