GCS do not upload zero - #1995
Merged
Merged
Conversation
chrisstaite-menlo
temporarily deployed
to
production
October 20, 2025 08:37 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
chrisstaite-menlo
temporarily deployed
to
production
October 20, 2025 08:37 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
chrisstaite-menlo
temporarily deployed
to
production
October 20, 2025 08:37 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Member
|
Can we get a test for this please! |
chrisstaite-menlo
force-pushed
the
feature/GCS-do-not-upload-zero
branch
from
October 21, 2025 09:34
afb564c to
7d6767e
Compare
chrisstaite-menlo
temporarily deployed
to
production
October 21, 2025 09:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
chrisstaite-menlo
had a problem deploying
to
production
October 21, 2025 09:35 — with
GitHub Actions
Error
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
October 21, 2025 09:35 — with
GitHub Actions
Error
GitHub Actions
Error
chrisstaite-menlo
force-pushed
the
feature/GCS-do-not-upload-zero
branch
from
October 21, 2025 09:41
7d6767e to
0bff82e
Compare
chrisstaite-menlo
temporarily deployed
to
production
October 21, 2025 09:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
chrisstaite-menlo
had a problem deploying
to
production
October 21, 2025 09:43 — with
GitHub Actions
Error
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
October 21, 2025 09:43 — with
GitHub Actions
Error
GitHub Actions
Error
We take pains not to attempt to fetch the zero byte digest from the GCS store, so we should avoid uploading it too. The stdout is usually zero bytes and uploading loads of them causes a lot of 429 errors. Add a check for the zero byte digest and error if it's not zero bytes.
chrisstaite-menlo
force-pushed
the
feature/GCS-do-not-upload-zero
branch
from
October 21, 2025 09:48
0bff82e to
628e378
Compare
chrisstaite-menlo
temporarily deployed
to
production
October 21, 2025 09:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
chrisstaite-menlo
temporarily deployed
to
production
October 21, 2025 09:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
chrisstaite-menlo
temporarily deployed
to
production
October 21, 2025 09:52 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
palfrey
approved these changes
Oct 21, 2025
MarcusSorealheis
pushed a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
We take pains not to attempt to fetch the zero byte digest from the GCS store, so we should avoid uploading it too. The stdout is usually zero bytes and uploading loads of them causes a lot of 429 errors. Add a check for the zero byte digest and error if it's not zero bytes.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We take pains not to attempt to fetch the zero byte digest from the GCS store, so we should avoid uploading it too. The stdout is usually zero bytes and uploading loads of them causes a lot of 429 errors.
Add a check for the zero byte digest and error if it's not zero bytes.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Tested with my Chromium build.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is