refactor methods to handle invalid transfers

[ankitsmt211]

• refactor bot transfer checks
• add check for too short message transfers
• resolves Transfer crashes on short messages #926

updates:

• transfer on short messages now opens up modal menu with empty question/text field with "untitled" as title.
• longer messages than max length are trimmed.

[ankitsmt211]

Question, if onMessageContext was a private method, would it be better to use assert instead of validation methods i did to ensure message is of required length for modal description?

[Zabuzard]

Question, if onMessageContext was a private method, would it be better to use assert instead of validation methods i did to ensure message is of required length for modal description?

Id prefer to not use assert. Its disabled unless u run a specific VM argument. Prefer using ordinary exceptions and the logger with its various logging levels instead. Theres also throw new AssertionError(...) if you want a good equivalent to an assert. Note that asserts are not for user-errors but to mark bugs in the code.

[ankitsmt211]

Id prefer to not use assert. Its disabled unless u run a specific VM argument. Prefer using ordinary exceptions and the logger with its various logging levels instead. Theres also throw new AssertionError(...) if you want a good equivalent to an assert. Note that asserts are not for user-errors but to mark bugs in the code.

True that was just curious, from what i understand assert also throws assertion error by default. But ye it needs to be enabled.