Skip to content

feat: add replaceValue... methods to MutableSolutionView#2180

Merged
triceo merged 6 commits intoTimefoldAI:mainfrom
triceo:smarter
Mar 13, 2026
Merged

feat: add replaceValue... methods to MutableSolutionView#2180
triceo merged 6 commits intoTimefoldAI:mainfrom
triceo:smarter

Conversation

@triceo
Copy link
Copy Markdown
Collaborator

@triceo triceo commented Mar 10, 2026 •
edited
Loading

In addition to moveValue...

Copilot AI review requested due to automatic review settings March 10, 2026 19:09
Copilot AI reviewed Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes moving and swapping elements inside planning list variables in MoveDirector, aiming to reduce per-move overhead on the solver hot path.

Changes:

  • Introduces a moveInList(...) helper that selects between Collections.rotate and remove+add based on move distance/position.
  • Updates moveValueInList(...) to use the new helper and return the moved value via the list after mutation.
  • Replaces manual swap logic with Collections.swap(...) in swapValuesInList(...).

Christopher-Chianelli
Christopher-Chianelli approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests are green.

@triceo
Copy link
Copy Markdown
Collaborator Author

triceo commented Mar 11, 2026

@Christopher-Chianelli Since I was already here, I decided to implement a feature request from the models. Please re-review, new code was added.

@winklerm Was this what you had in mind?

@triceo triceo linked an issue Mar 11, 2026 that may be closed by this pull request
Feat: MutableSolutionView.replaceValue() #2181
Closed
@triceo triceo added this to the v2.0.0 milestone Mar 11, 2026
@triceo triceo requested a review from Copilot March 11, 2026 08:29
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

@triceo triceo requested a review from Copilot March 11, 2026 09:36
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Copilot AI review requested due to automatic review settings March 11, 2026 10:13
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot AI review requested due to automatic review settings March 11, 2026 10:31
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings March 11, 2026 10:36
Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@triceo triceo changed the title perf: improve value move within a list feat: add replaceValue... methods to MutableSolutionView Mar 11, 2026
@winklerm
Copy link
Copy Markdown
Contributor

winklerm commented Mar 11, 2026

@winklerm Was this what you had in mind?

Yes, thank you very much!!

Christopher-Chianelli
Christopher-Chianelli approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM; although I think a better name can be chosen for replaceValueBetweenLists.

@triceo triceo removed this from the v2.0.0 milestone Mar 13, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@triceo triceo merged commit 6c99a5b into TimefoldAI:main Mar 13, 2026
19 checks passed
@triceo triceo deleted the smarter branch March 13, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Christopher-Chianelli Christopher-Chianelli Christopher-Chianelli approved these changes

+1 more reviewer

@winklerm winklerm winklerm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@triceo triceo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat: MutableSolutionView.replaceValue()

4 participants

@triceo @winklerm @Christopher-Chianelli