fix: don't test the filtering joiner if a tuple is already retracting#1850
Merged
triceo merged 7 commits intoTimefoldAI:mainfrom Oct 1, 2025
Merged
fix: don't test the filtering joiner if a tuple is already retracting#1850triceo merged 7 commits intoTimefoldAI:mainfrom
triceo merged 7 commits intoTimefoldAI:mainfrom
Conversation
triceo
requested review from
Christopher-Chianelli and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/main/java/ai/timefold/solver/core/impl/bavet/common/AbstractJoinNode.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/bavet/common/AbstractIfExistsNode.java
Show resolved
Hide resolved
Christopher-Chianelli
approved these changes
Oct 1, 2025
core/src/main/java/ai/timefold/solver/core/impl/bavet/common/AbstractJoinNode.java
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/impl/bavet/common/AbstractIfExistsNode.java
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The included tests describe the problematic situation.
The comments in the code explain the solution.