Skip to content

Fix BinarySearch not-found return value #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nargeslein wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −13
Open

Fix BinarySearch not-found return value #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions src/Searches/BinarySearch.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,17 @@ contract BinarySearch {
}

// returns the index position of the value in the array
function printResult() public view returns (uint256 result) {
function printResult() public view returns (int256 result) {
uint256 minimum = 0;
uint256 maximum = _nums.length - 1;
uint256 maximum = _nums.length;

while (minimum <= maximum) {
uint256 middle = (minimum + maximum) / 2;
while (minimum < maximum) {
uint256 middle = minimum + (maximum - minimum) / 2;
uint256 currentElement = _nums[middle];
if (currentElement < value) {
minimum = middle + 1;
}
else if (currentElement > value) {
if (middle == 0) {
maximum = 0;
} else {
maximum = middle - 1;
}
} else if (currentElement > value) {
maximum = middle;
} else {
result = int256(middle);
// return the index position of the value in the array
Expand Down
11 changes: 9 additions & 2 deletions src/Searches/test/BinarySearch.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,15 @@ contract BinarySearchTest is Test {
/// @dev Test `BinarySearch`

function test_BinarySearch() external {
uint searchedIndex = bs.printResult();
uint expectedIndex = 9;
int searchedIndex = bs.printResult();
int expectedIndex = 9;
assertEq(expectedIndex, searchedIndex);
}

function test_BinarySearchNotFound() external {
bs.setValue(21);
int searchedIndex = bs.printResult();
int expectedIndex = -1;
assertEq(expectedIndex, searchedIndex);
}
}