update segmenttree docstrings Fixes #9943#9975
Merged
cclauss merged 3 commits intoTheAlgorithms:masterfrom Oct 17, 2023
Merged
Conversation
Contributor
Author
|
@cclauss please approve this PR for hacktoberfest and add the hacktoberfest-accepted label after PR merging. Thank you! |
cclauss
reviewed
Oct 7, 2023
Comment on lines
8
to
10
| self.st = [0] * ( | ||
| 4 * self.N | ||
| ) # approximate the overall size of segment tree with array N |
Member
There was a problem hiding this comment.
I gotta say that overall I am not a fan of these single variable names and uppercase variable names!!!
This looks like it was literally ported from some other language with minimal modifications.
a has no data type and no self-documenting name and the class version is uppercase. If find it unreadable.
Suggested change
| self.st = [0] * ( | |
| 4 * self.N | |
| ) # approximate the overall size of segment tree with array N | |
| # approximate the overall size of the segment tree with array N | |
| self.st = [0] * (4 * self.N) |
Contributor
Author
There was a problem hiding this comment.
Agreed, I'll make an issue for people to tackle naming issues in the repository, seems like it was an older thing
cclauss
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: