Match a pattern and String using backtracking#9861
Match a pattern and String using backtracking#9861chriso345 merged 33 commits intoTheAlgorithms:masterfrom
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
backtracking/match_word_pattern.py
Outdated
| @@ -0,0 +1,54 @@ | |||
| def matchWordPattern(pattern :str, input_string: str) -> bool: | |||
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: matchWordPattern
backtracking/match_word_pattern.py
Outdated
| >>> matchWordPattern("GG", "PythonJavaPython") | ||
| False | ||
| """ | ||
| def backtrack(pattern_index, str_index): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file backtracking/match_word_pattern.py, please provide doctest for the function backtrack
Please provide return type hint for the function: backtrack. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: pattern_index
Please provide type hint for the parameter: str_index
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
backtracking/match_word_pattern.py
Outdated
| >>> match_word_pattern("GG", "PythonJavaPython") | ||
| False | ||
| """ | ||
| def backtrack(pattern_index, str_index): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file backtracking/match_word_pattern.py, please provide doctest for the function backtrack
Please provide return type hint for the function: backtrack. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: pattern_index
Please provide type hint for the parameter: str_index
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
backtracking/match_word_pattern.py
Outdated
| False | ||
| """ | ||
|
|
||
| def backtrack(pattern_index, str_index): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file backtracking/match_word_pattern.py, please provide doctest for the function backtrack
Please provide return type hint for the function: backtrack. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: pattern_index
Please provide type hint for the parameter: str_index
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
backtracking/match_word_pattern.py
Outdated
| False | ||
| """ | ||
|
|
||
| def backtrack(pattern_index, str_index): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file backtracking/match_word_pattern.py, please provide doctest for the function backtrack
Please provide return type hint for the function: backtrack. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: pattern_index
Please provide type hint for the parameter: str_index
algorithms-keeper
bot
removed
require tests
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
awaiting reviews
2 participants
Describe your change:
created a file with name match_word_pattern.py inside backtracking for Match a pattern and String using backtracking.
Checklist: