Skip to content

Mention square matrices in strassen docs and make it more clear#9839

Merged
tianyizheng02 merged 2 commits intoTheAlgorithms:masterfrom
saahil-mahato:strassen-doc-correction
Oct 7, 2023
Merged

Mention square matrices in strassen docs and make it more clear#9839
tianyizheng02 merged 2 commits intoTheAlgorithms:masterfrom
saahil-mahato:strassen-doc-correction

Conversation

@saahil-mahato
Copy link
Contributor

@saahil-mahato saahil-mahato commented Oct 5, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 5, 2023
@saahil-mahato saahil-mahato changed the title refactor: fix strassen matrix multiplication docs Mention square matrices in strassen docs and make it more clear Oct 5, 2023
@tianyizheng02 tianyizheng02 merged commit 678e0aa into TheAlgorithms:master Oct 7, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 7, 2023
@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Oct 7, 2023

Thanks for your fix!

tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request Oct 8, 2023
@saahil-mahato @tianyizheng02
Mention square matrices in strassen docs and make it more clear (TheA…
b377882 
…lgorithms#9839)

* refactor: fix strassen matrix multiplication docs

* refactor: make docs more clear
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saahil-mahato @tianyizheng02