convert to the base minus 2 of a number#9748
Merged
cclauss merged 20 commits intoTheAlgorithms:masterfrom Oct 5, 2023
Merged
Conversation
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/base_neg2_conversion.py
Outdated
| @@ -0,0 +1,37 @@ | |||
| import doctest | |||
| def decimal_to_negative_base_2(n): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: decimal_to_negative_base_2. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: n
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/base_neg2_conversion.py
Outdated
| @@ -0,0 +1,39 @@ | |||
| import doctest | |||
| def decimal_to_negative_base_2(n): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: decimal_to_negative_base_2. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: n
Please provide descriptive name for the parameter: n
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/base_neg2_conversion.py
Outdated
| @@ -0,0 +1,38 @@ | |||
| import doctest | |||
| def decimal_to_negative_base_2(n: int) -> int: | |||
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
algorithms-keeper
bot
removed
the
require descriptive names
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
Closed
Member
|
Please change the title of this pull request so we know what it does. |
haxkd
changed the title
haxkd
changed the title
haxkd
changed the title
haxkd
changed the title
cclauss
changed the title
cclauss
reviewed
Oct 5, 2023
maths/base_neg2_conversion.py
Outdated
| ans = "" | ||
| while num != 0: | ||
| rem = num % -2 | ||
| num = num // -2 |
Member
There was a problem hiding this comment.
Let's use https://docs.python.org/3/library/functions.html#divmod instead
cclauss
reviewed
Oct 5, 2023
for more information, see https://pre-commit.ci
cclauss
approved these changes
Oct 5, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
This was referenced Oct 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes: #9588
Added maths/base_neg2_conversion.py.
Checklist: