serialize deserialize binary tree#9625
Conversation
algorithms-keeper
bot
added
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| right: The right child of the node. | ||
| """ | ||
|
|
||
| def __init__(self, val: int = 0, left=None, right=None) -> None: |
There was a problem hiding this comment.
Please provide type hint for the parameter: left
Please provide type hint for the parameter: right
| # Split the serialized string by comma to get node values | ||
| nodes = data.split(",") | ||
|
|
||
| def build_tree(): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_deserialize_binary_tree.py, please provide doctest for the function build_tree
Please provide return type hint for the function: build_tree. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
bot
removed
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Split the serialized string by comma to get node values | ||
| nodes = data.split(",") | ||
|
|
||
| def build_tree() -> TreeNode | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_deserialize_binary_tree.py, please provide doctest for the function build_tree
algorithms-keeper
bot
added
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| left: TreeNode | None = None | ||
| right: TreeNode | None = None | ||
|
|
||
| def __post_init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __post_init__. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_deserialize_binary_tree.py, please provide doctest for the function __post_init__
| # Split the serialized string by a comma to get node values | ||
| nodes = data.split(",") | ||
|
|
||
| def build_tree() -> TreeNode | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/serialize_deserialize_binary_tree.py, please provide doctest for the function build_tree
algorithms-keeper
bot
removed
the
awaiting reviews
3 participants
Describe your change:
Fixes #9611
Checklist: