Skip to content

Upgrade to Python 3.12#9576

Merged
cclauss merged 5 commits intomasterfrom
Py3.12
Oct 3, 2023
Merged

Upgrade to Python 3.12#9576
cclauss merged 5 commits intomasterfrom
Py3.12

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Oct 3, 2023 •
edited
Loading

Describe your change:

Repeats #8777
Repeats #9306

Disables algorithms based on qiskit and tensorflow because those modules are not yet compatible with Python 3.12.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added documentation This PR modified documentation files awaiting reviews This PR is ready to be reviewed labels Oct 3, 2023
@cclauss cclauss enabled auto-merge (squash) October 3, 2023 08:25
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 3, 2023
dhruvmanila
dhruvmanila approved these changes Oct 3, 2023
View reviewed changes
.github/workflows/build.yml
with:
python-version: 3.11
python-version: 3.12
allow-prereleases: true
Copy link
Member

@dhruvmanila dhruvmanila Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this now, right?

Copy link
Member Author

@cclauss cclauss Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will allow me to play with Python 3.11 and will sit dorment until we update line 15.

requirements.txt
Comment on lines +12 to +20
qiskit ; python_version < '3.12'
qiskit-aer ; python_version < '3.12'
requests
rich
scikit-fuzzy
scikit-learn
statsmodels
sympy
tensorflow
tensorflow ; python_version < '3.12'
Copy link
Member

@dhruvmanila dhruvmanila Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should open a tracking issue for remaining dependencies and mark it as "good first issue".

@cclauss cclauss merged commit 0f4e512 into master Oct 3, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 3, 2023
@cclauss cclauss deleted the Py3.12 branch October 3, 2023 09:25
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@tianyizheng02 tianyizheng02 Awaiting requested review from tianyizheng02

Assignees

No one assigned

Labels

documentation This PR modified documentation files tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @dhruvmanila