Merged
Conversation
updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292) - [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6) - [github.com/tox-dev/pyproject-fmt: 1.1.0 → 1.2.0](tox-dev/pyproject-fmt@1.1.0...1.2.0)
pre-commit-ci
bot
requested review from
cclauss and
dhruvmanila
as code owners
Contributor
|
The pre-commit failures are coming from typos in various files |
|
hi, @tianyizheng02 could you assign this pr to me |
Member
|
You can |
algorithms-keeper
bot
added
the
merge conflicts
algorithms-keeper
bot
removed
the
merge conflicts
Contributor
@cclauss I didn't want to have codespell auto-fix the typos because some of them are false positives. Currently codespell is failing because it thinks "Manuel" (the name) is a misspelling of "Manual". |
|
|
||
| [tool.codespell] | ||
| ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,mater,secant,som,sur,tim,zar" | ||
| ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,zar" |
Contributor
There was a problem hiding this comment.
Suggested change
| ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,manuel,mater,secant,som,sur,tim,zar" | |
| ignore-words-list = "3rt,ans,crate,damon,fo,followings,hist,iff,kwanza,Manuel,mater,secant,som,sur,tim,zar" |
Not entirely sure how codespell handles ignored words, but would this help codespell recognize "Manuel" as a name while still catching "manuel" as a typo?
Member
There was a problem hiding this comment.
These values MUST all be in lowercase as discussed in the codespell docs.
Tests seem to be passing below.
tianyizheng02
approved these changes
Oct 7, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
tianyizheng02
added a commit
to tianyizheng02/Python
that referenced
this pull request
Oct 8, 2023
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/astral-sh/ruff-pre-commit: v0.0.291 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.291...v0.0.292) - [github.com/codespell-project/codespell: v2.2.5 → v2.2.6](codespell-project/codespell@v2.2.5...v2.2.6) - [github.com/tox-dev/pyproject-fmt: 1.1.0 → 1.2.0](tox-dev/pyproject-fmt@1.1.0...1.2.0) * updating DIRECTORY.md * Fix typos in test_min_spanning_tree_prim.py * Fix typos * codespell --ignore-words-list=manuel --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com> Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates: