Add typing to binary_exp_mod.py#9469
Merged
tianyizheng02 merged 3 commits intoTheAlgorithms:masterfrom Oct 2, 2023
Merged
Conversation
algorithms-keeper
bot
added
enhancement
This was referenced Oct 2, 2023
tianyizheng02
requested changes
Oct 2, 2023
maths/binary_exp_mod.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| def bin_exp_mod(a, n, b): | |||
| def bin_exp_mod(a: int, n: float, b: int) -> int: | |||
Contributor
There was a problem hiding this comment.
Suggested change
| def bin_exp_mod(a: int, n: float, b: int) -> int: | |
| def bin_exp_mod(a: int, n: int, b: int) -> int: |
n here is actually supposed to be an integer, not a float
Contributor
Author
There was a problem hiding this comment.
right that was my first change too, but linter fails on that: 606d844
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I believe that might be due to the float division / on line 16. Could you try changing that to integer division //?
Contributor
Author
There was a problem hiding this comment.
@tianyizheng02 thanks this works, also TIL :)
updated similar change on other diff too
tianyizheng02
approved these changes
Oct 2, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: