Conversation
|
Hi @cclauss, Can you take a look at this. Thanks. |
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
make code more readable
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
Please let me try something... |
for more information, see https://pre-commit.ci
|
Any questions about these changes? 0207354 Tuples are smaller in memory than lists and they cannot be modified at runtime which can be an advantage for data safety. For the doctests, we do not need to test every element but the length and the first and the last is a good idea. |
for more information, see https://pre-commit.ci
cclauss
left a comment
There was a problem hiding this comment.
Nice one! Thanks for your patience.
Yeah. This makes sense. Thanks. |
Describe your change:
Added a new algorithm to solve the gas station problem. I added the file
gas_station.pyto thegreedy_methodsdirectory. I have also added docstrings for the function with an explanation and doctests.Checklist: