Skip to content

Fixed file name in transposition_cipher_encrypt_decrypt_file.py. Fixing bug file not found.#9426

Merged
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
aryan1165:transposition
Oct 4, 2023
Merged

Fixed file name in transposition_cipher_encrypt_decrypt_file.py. Fixing bug file not found.#9426
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
aryan1165:transposition

Conversation

@aryan1165
Copy link
Contributor

@aryan1165 aryan1165 commented Oct 2, 2023 •
edited
Loading

Describe your change:

Fixed file name in transposition_cipher_encrypt_decrypt_file.py. Fixing bug file not found.
As mentioned in PR #9263 by @tianyizheng02.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 2, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 2, 2023
tianyizheng02
tianyizheng02 reviewed Oct 3, 2023
View reviewed changes
ciphers/prehistoric_men.txt
Copy link
Contributor

@tianyizheng02 tianyizheng02 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly was changed in this text file?

Copy link
Contributor Author

@aryan1165 aryan1165 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a character which was not being recognized. It was producing an error of character out of range. I think it was part of unicode or some other character set.

@tianyizheng02 tianyizheng02 merged commit 700df39 into TheAlgorithms:master Oct 4, 2023
@aryan1165 aryan1165 deleted the transposition branch October 4, 2023 03:35
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aryan1165 @tianyizheng02