Skip to content

added algorithm to remove duplicates from a linked list#9395

Closed
pa-kh039 wants to merge 6 commits intoTheAlgorithms:masterfrom
pa-kh039:new-branch
Closed

added algorithm to remove duplicates from a linked list#9395
pa-kh039 wants to merge 6 commits intoTheAlgorithms:masterfrom
pa-kh039:new-branch

Conversation

@pa-kh039
Copy link
Contributor

@pa-kh039 pa-kh039 commented Oct 2, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the require type hints https://docs.python.org/3/library/typing.html label Oct 2, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 2, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

data_structures/linked_list/remove_duplicates.py Outdated
temp_node.next_node = new_node
return head

def remove_duplicates(head:Node | None):
Copy link

@algorithms-keeper algorithms-keeper bot Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: remove_duplicates. If the function does not return a value, please provide the type hint as: def function() -> None:

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 2, 2023
@pa-kh039
Copy link
Contributor Author

pa-kh039 commented Oct 2, 2023

@cclauss resolved the issues in the PR #9330 as was hinted by you while closing my previous PR #9326 while merging another PR #9323 .
Please review and merge @cclauss @tianyizheng02

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 2, 2023
@algorithms-keeper algorithms-keeper bot removed require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass labels Oct 2, 2023
@cclauss
Copy link
Member

cclauss commented Oct 2, 2023

Please do not request reviews of pull requests when the tests are failing.

I wrote #9323 (review) and that is the way that I would like us to deal with all new linked list algorithms.

@pa-kh039
Copy link
Contributor Author

pa-kh039 commented Oct 2, 2023 •
edited
Loading

@cclauss all checks have passed, sorry for the trouble caused

cclauss
cclauss requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need class LinkedList: like:
https://github.com/TheAlgorithms/Python/blob/master/data_structures/linked_list/reverse_k_group.py#L13

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 2, 2023
@algorithms-keeper algorithms-keeper bot added the require descriptive names This PR needs descriptive function and/or variable names label Oct 4, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Oct 4, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

dynamic_programming/distinct_subsequences.py
@@ -0,0 +1,46 @@
from future import __annotations__

def subsequenceCounting(s1: str, s2: str, n: int, m: int) -> int:
Copy link

@algorithms-keeper algorithms-keeper bot Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: subsequenceCounting

Please provide descriptive name for the parameter: n

Please provide descriptive name for the parameter: m

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 4, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 4, 2023
@pa-kh039 pa-kh039 closed this Oct 4, 2023
@pa-kh039 pa-kh039 deleted the new-branch branch October 4, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss requested changes

+1 more reviewer

@algorithms-keeper algorithms-keeper[bot] algorithms-keeper[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pa-kh039 @cclauss