Removed redundant greatest_common_divisor code

[Siddikpatel]

Describe your change:

Previously all the files that needed greatest_common_divisor (aka gcd), used to define the method instead of just importing from Maths directory's greatest_common_divisor.py file. I removed thos definitions and imported gcd method from Maths folder. Fixes #8098

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

[Siddikpatel]

It says organize imports. Don't know what to do about that. Otherwise there are no issues

[tianyizheng02]

@Siddikpatel Please run ruff --fix . locally to have ruff auto-sort the imports

[Siddikpatel]

Fixed the import issues!

[tianyizheng02]

I just remembered that the Python math module already has a gcd function. @cclauss, do you think it's better for our files to simply import gcd from math? Or is it better for our files to use our own implementation?

[tianyizheng02]

BTW, @Siddikpatel, there are even more duplicate implementations of gcd if you search for "gcd" in the repo (for example, in maths/carmichael_number.py), so those could be removed as well

[Siddikpatel]

BTW, @Siddikpatel, there are even more duplicate implementations of gcd if you search for "gcd" in the repo (for example, in maths/carmichael_number.py), so those could be removed as well

and, what about those files that imports gcd from math module of python?

[tianyizheng02]

and, what about those files that imports gcd from math module of python?

Those are fine—it's fine to import functions as helper functions as long as it doesn't include the core of the actual algorithm

[tianyizheng02]

Looks good, but the merge conflict will need to be fixed. I can't fix it myself because I don't have write permission, so could you fix it?

[Siddikpatel]

Looks good, but the merge conflict will need to be fixed. I can't fix it myself because I don't have write permission, so could you fix it?

Ok I am confused now.. It says merge conflicts in modular_division.py.

[tianyizheng02]

OK, I see what happened: a previous PR moved blockchain/modular__division.py to the maths directory, and that's causing a merge conflict here because you still have the file in the blockchain directory. I'm guessing that the conflict will be resolved if you move the file to the maths directory as well?

[Siddikpatel]

Yup, it is fixed now.

[tianyizheng02]

It says the file was deleted... did you not move it into the maths module?

[Siddikpatel]

It says the file was deleted... did you not move it into the maths module?

I've moved it to maths directory.

[quant12345]

@tianyizheng02 @cclauss A couple of days ago carmichael_number - add doctests. Do I need to delete this pull request (in 'Files changed' there is gcd)? At the bottom there was an inscription about a merge conflict. I made edits taking into account greatest_common_divisor. Now there is no warning. But will there be problems if there is a merger?

[tianyizheng02]

No, there shouldn't be any problems. This PR has already been merged so it can't be "deleted" anyway. For your other PR, GitHub will merge it into the updated codebase, the one with this PR already merged.