add Three sum#9177
add Three sum#9177cclauss merged 14 commits intoTheAlgorithms:masterfrom BamaCharanChhandogi:add/three-sum
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
maths/three_sum.py
Outdated
| @@ -0,0 +1,44 @@ | |||
| def threeSum(nums: list[int]) -> list[list[int]]: | |||
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: threeSum
for more information, see https://pre-commit.ci
|
@cclauss can you check? |
cclauss
left a comment
There was a problem hiding this comment.
Is there any practical use for this algorithm?
|
Please put the uses in the docstring where they will be seen, not in these review comments where they will be lost. |
OK, I will add in docstring. |
|
hello @cclauss, Next Please give a review. |
|
Hey @dhruvmanila @cclauss, I have a question after merging this PR why are 2 checks passed? |
Describe your change:
Checklist: