Rewrite of base32.py algorithm#9068
Merged
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom Sep 24, 2023
Merged
Conversation
Contributor
|
@chriso345 Put fixes #8965 in the description please |
Contributor
|
Now build will pass as #9078 is merged. |
tianyizheng02
requested changes
Sep 24, 2023
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
tianyizheng02
approved these changes
Sep 24, 2023
Contributor
|
@chriso345 Thanks for the rewrite! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #8966
Fixes #8965
See #6216
Checklist: