Added an add at position subroutiune to linked list by mendacium-a11y · Pull Request #9020 · TheAlgorithms/Python

mendacium-a11y · 2023-08-30T11:16:10Z

Describe your change:

This pull request adds the add_at_position function to the linked list implementation. This function allows inserting an item at a specified position within the linked list.

Checklist:

CaedenPH · 2023-08-30T21:06:22Z

data_structures/linked_list/__init__.py

+        >>> linked_list.add(3)
+        >>> linked_list.add_at_position(10, 1)
+        True
+


Here there should be a test displaying linked_list

CaedenPH · 2023-08-30T21:07:55Z

data_structures/linked_list/__init__.py

+            current = current.next
+            counter += 1
+
+        if current:  # Check if current is not None


Suggested change

if current: # Check if current is not None

if current is not None:

CaedenPH · 2023-08-30T21:08:19Z

data_structures/linked_list/__init__.py

+        else:
+            return False


Suggested change

else:

return False

return False

CaedenPH · 2023-08-30T21:08:54Z

data_structures/linked_list/__init__.py

+        if position < 0:
+            return False


Maybe this should raise an error?

Suggested change

if position < 0:

return False

if 0 > position:

return False

This also looks a bit more readable

CaedenPH · 2023-08-30T21:09:30Z

data_structures/linked_list/__init__.py

        self.head = Node(item, self.head)
        self.size += 1

+    def add_at_position(self, item: Any, position: int) -> bool:


What about insert_at_position?

data_structures/linked_list/__init__.py

mendacium-a11y · 2023-09-06T02:32:40Z

updated the the code by dropping the add_at_position, instead updated the add function to take an optional position argument to specify of we want to insert the node at a specific position in the linked list

tianyizheng02 · 2023-09-07T00:05:59Z

CONTRIBUTING.md

@@ -1,4 +1,4 @@
-# Contributing guidelines
+<!-- # Contributing guidelines -->


Don't edit the contributing guidelines

this seems to have happened by mistake, didn't intend to

Suggested change



# Contributing guidelines

Then please uncomment this line

data_structures/linked_list/__init__.py

…t less than 0 or not

mendacium-a11y · 2023-09-07T06:21:28Z

added the doctest and updated the else code after checking the position is 0 or not

data_structures/linked_list/__init__.py

tianyizheng02 · 2023-09-07T07:06:47Z

CONTRIBUTING.md

@@ -1,4 +1,4 @@
-# Contributing guidelines
+<!-- # Contributing guidelines -->


Suggested change



# Contributing guidelines

Then please uncomment this line

…itive

mendacium-a11y · 2023-09-08T05:20:01Z

fixed contributing.md and added the doctest for checing out of bounds posiiton, both positive and negative

tianyizheng02 · 2023-09-08T12:20:38Z

Thanks for your contribution!

mendacium-a11y added 2 commits August 30, 2023 16:34

added addAtPosition to simple linked list

8e8bea6

added addAtPosition to simple linked list

a6fbb44

mendacium-a11y changed the title ~~Linked list~~ Added an add at position subroutiune to linked list Aug 30, 2023

CaedenPH reviewed Aug 30, 2023

View reviewed changes

tianyizheng02 requested changes Sep 5, 2023

View reviewed changes

data_structures/linked_list/__init__.py Show resolved Hide resolved

modified the add function to take an optional position command

e00d58e

algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Sep 5, 2023

mendacium-a11y added 4 commits September 6, 2023 07:22

fixed type safety errors:

823da1b

fixed type safety errors:

142d318

fixed type safety errors:

a78cda0

fixed type safety errors:

b4485c5

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 6, 2023

fixed size error

6623820

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 6, 2023

fixed size error

8b33a4b

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 6, 2023

tianyizheng02 requested changes Sep 7, 2023

View reviewed changes

mendacium-a11y added 3 commits September 7, 2023 11:02

added doctest and updates the else after checking if posiiton argumen…

a07cf7f

…t less than 0 or not

Merge branch 'master' into linkedList

0aa274b

added doctest and updates the else after checking if posiiton argumen…

4a32c1f

…t less than 0 or not

tianyizheng02 requested changes Sep 7, 2023

View reviewed changes

mendacium-a11y added 2 commits September 8, 2023 10:33

fixed the contributing.md mistake

46cbb2b

added doctest for out of bounds position value, both negative and pos…

542d795

…itive

tianyizheng02 approved these changes Sep 8, 2023

View reviewed changes

tianyizheng02 merged commit c9b4b80 into TheAlgorithms:master Sep 8, 2023

mendacium-a11y deleted the linkedList branch September 9, 2023 07:02

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks

	if current: # Check if current is not None
	if current is not None:

		@@ -1,4 +1,4 @@
		# Contributing guidelines
		<!-- # Contributing guidelines -->

Uh oh!

Conversation

mendacium-a11y commented Aug 30, 2023

Describe your change:

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mendacium-a11y commented Sep 6, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mendacium-a11y commented Sep 7, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mendacium-a11y commented Sep 8, 2023

Uh oh!

tianyizheng02 commented Sep 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants