Move and reimplement convert_number_to_words.py#8998
Merged
cclauss merged 2 commits intoTheAlgorithms:masterfrom Aug 20, 2023
Merged
Move and reimplement convert_number_to_words.py#8998cclauss merged 2 commits intoTheAlgorithms:masterfrom
convert_number_to_words.py#8998cclauss merged 2 commits intoTheAlgorithms:masterfrom
Conversation
- Move convert_number_to_words.py from web_programming/ to conversions/ - Reimplement the algorithm from scratch because the logic was very opaque and too heavily nested - Add support for the Western numbering system (both short and long) because the original implementation only supported the Indian numbering system - Add extensive doctests and error handling
convert_number_to_words.py
cclauss
approved these changes
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
convert_number_to_words.pyfromweb_programming/toconversions/(fixesweb_programming/convert_number_to_words.pyis not web programming #8881)Checklist: