Fix get top billionaires BROKEN file#8970
Merged
tianyizheng02 merged 8 commits intoTheAlgorithms:masterfrom Aug 18, 2023
Merged
Fix get top billionaires BROKEN file#8970tianyizheng02 merged 8 commits intoTheAlgorithms:masterfrom
tianyizheng02 merged 8 commits intoTheAlgorithms:masterfrom
Conversation
…h/python into fix-get-top-billionaires
14 tasks
Contributor
Author
|
@cclauss This pr also fixes a broken file. The problem was that the unix timestamps were negative (if the billionaire is older than 53) which python causes python datetime to error (overflow error) |
tianyizheng02
requested changes
Aug 18, 2023
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
Could we change the doctests so that we don't have to update the ages every year? (see previous comment)
14 tasks
tianyizheng02
approved these changes
Aug 18, 2023
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
Tried it locally, looks like it works 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes a
get_top_billionairesand unmarks it as disabledChecklist: