Update arc_length.py#8964
Merged
tianyizheng02 merged 5 commits intoTheAlgorithms:masterfrom Aug 20, 2023
Merged
Conversation
Wrote the output of testcase
for more information, see https://pre-commit.ci
madhavgaba
approved these changes
Aug 16, 2023
tianyizheng02
requested changes
Aug 16, 2023
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
Instead of adding the expected output as a comment, could you add this as a test in the docstring?
>>> arc_length(90, 10)
15.7079632679That way, we can use unit testing to ensure that the output is actually correct.
Added the requested changes
Contributor
Author
|
Changes made |
This comment was marked as off-topic.
This comment was marked as off-topic.
tianyizheng02
requested changes
Aug 17, 2023
followed the change request
tianyizheng02
requested changes
Aug 19, 2023
followed suggestions
tianyizheng02
approved these changes
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote the output of testcase
Describe your change:
Added a comment to show output of the testcase.
Please tell me if I made an error, thank you.
Checklist: