Consolidate find_min and find_min recursive and find_max and find_max_recursive#8960
Merged
tianyizheng02 merged 5 commits intoTheAlgorithms:masterfrom Aug 14, 2023
Merged
Conversation
Contributor
Author
|
@tianyizheng02 What is your opinion of merging the recursive and iterative implementations into one file? Could also add benchmarks to compare the difference in time complexity between the implementations |
Contributor
|
I support these kinds of file merges. Like you said, it helps with benchmarking, but it also just makes it much easier to compare different implementations in general Also helps with resolving #8098, of course |
tianyizheng02
requested changes
Aug 14, 2023
Contributor
There was a problem hiding this comment.
Now that this file also contains the recursive implementation, we should probably rename the existing find_max to find_max_iterative to contrast it with the recursive one.
Contributor
There was a problem hiding this comment.
find_min() -> find_min_iterative() (see previous comment)
tianyizheng02
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Merges
find_minandfind_min_recursiveinto justfind_min.Merges
find_minandfind_max_recursiveinto justfind_max.Checklist: