Conversation
for more information, see https://pre-commit.ci
|
Having found an error in the course that taught this simplex algorithm, I ask you to review my changes once more, @cclauss |
|
@CaedenPH sorry about the number of commits; I had issues with ruff etc. Could you please check this version? |
|
To clarify, the old version couldn't optimally solve certain problems like the one I inserted on lines 270-286 in a doctest. I only realised this after that version was merged, given that it is a rare case. I adapted the implementation of other courses to fix this issue, but took the opportunity to add more doctests and checks. |
CaedenPH
left a comment
There was a problem hiding this comment.
Nice change, thanks for adding the extra doctests.
@tianyizheng02 Pinging for review
tianyizheng02
left a comment
There was a problem hiding this comment.
Honestly I'm not super familiar with the simplex algorithm, so I can't confirm whether this fixes the implementation—but the code itself looks good to me
Describe your change:
I discovered that the algorithm I used initially gives suboptimal solutions when a pivot on a slack column is required; the algorithm terminates prematurely.
This pull request changes function inputs and doctests to reflect changes made to the steps of the algorithm. Mainly:
Checklist: