Fix removing the root node in binary_search_tree.py removes the whole tree#8819
Closed
kartheekkotha wants to merge 2 commits intoTheAlgorithms:masterfrom
kartheekkotha:master
Closed
Fix removing the root node in binary_search_tree.py removes the whole tree#8819kartheekkotha wants to merge 2 commits intoTheAlgorithms:masterfrom kartheekkotha:master
kartheekkotha wants to merge 2 commits intoTheAlgorithms:masterfrom
kartheekkotha:master
Conversation
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
tests are failing
cclauss
reviewed
Jun 18, 2023
Comment on lines
+40
to
+43
| if self.is_right(node): # If it is the right children | ||
| self.root = new_children | ||
| else: | ||
| self.root = new_children |
Member
There was a problem hiding this comment.
Why execute the if statement when the code executed is identical either way?
cclauss
reviewed
Jun 18, 2023
Comment on lines
+37
to
+39
| if ( | ||
| node == self.root | ||
| ): # This check if the node is the head and assign the root to the remaining |
Member
There was a problem hiding this comment.
Please do not wrap line for a comment.
Suggested change
| if ( | |
| node == self.root | |
| ): # This check if the node is the head and assign the root to the remaining | |
| # This check if the node is the head and assigns the root to the remaining | |
| if node == self.root: |
cclauss
changed the title
Contributor
|
#8752 also implements the same issue. Which pr should be merged? |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fixes #8715
Checklist:
Fixes: #{$ISSUE_NO}.