Handle empty input case in Segment Tree build process#8718
Merged
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom Jul 31, 2023
Merged
Handle empty input case in Segment Tree build process#8718tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
Conversation
rohan472000
suggested changes
May 12, 2023
Contributor
rohan472000
left a comment
There was a problem hiding this comment.
To resolve this issue, you need to modify the type annotations, Instead of the current syntax, you should use the X | Y syntax.
Contributor
Author
|
Thank you for your advice. However, that part wasn't contributed by me, so I'm unsure if I can make corrections to it. I've recently updated my branch following the merge of a PR that made changes to |
Contributor
Author
|
@rohan472000 |
|
Hi Alex,
We have received you request, I've escalated the source files and the
linguists files for the CAT analysis.
Once it done we'll proceed at the earliest.
Let me know if you have any queries.
Happy Weekend.
Umaire Firoz
…On Tue, May 9, 2023, 20:14 roger-sato ***@***.***> wrote:
Describe your change:
- Add an algorithm?
- Fix a bug or typo in an existing algorithm?
- Documentation change?
Checklist:
- I have read CONTRIBUTING.md
<https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md>.
- This pull request is all my own work -- I have not plagiarized.
- I know that pull requests will not be merged if they fail the
automated tests.
- This PR only changes one algorithm file. To ease review, please open
separate PRs for separate algorithms.
- All new Python files are placed inside an existing directory.
- All filenames are in all lowercase characters with no spaces or
dashes.
- All functions and variable names follow Python naming conventions.
- All function parameters and return values are annotated with Python type
hints <https://docs.python.org/3/library/typing.html>.
- All functions have doctests
<https://docs.python.org/3/library/doctest.html> that pass the
automated testing.
- All new algorithms include at least one URL that points to Wikipedia
or another similar explanation.
- If this pull request resolves one or more open issues then the
commit message contains Fixes: #{$ISSUE_NO}.
------------------------------
You can view, comment on, or merge this pull request online at:
#8718
Commit Summary
- 438c795
<438c795>
Handle empty input case in Segment Tree build process
File Changes
(1 file <https://github.com/TheAlgorithms/Python/pull/8718/files>)
- *M* data_structures/binary_tree/segment_tree.py
<https://github.com/TheAlgorithms/Python/pull/8718/files#diff-e4cd820e81e6599a55a8c71fa60e4bff2696d46c7f2802fedae2524596cde556>
(3)
Patch Links:
- https://github.com/TheAlgorithms/Python/pull/8718.patch
- https://github.com/TheAlgorithms/Python/pull/8718.diff
—
Reply to this email directly, view it on GitHub
<#8718>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJK2QAF247LCCLLYW4NSBO3XFJJ5LANCNFSM6AAAAAAX3M2CUQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
tianyizheng02
approved these changes
Jul 31, 2023
Contributor
tianyizheng02
left a comment
There was a problem hiding this comment.
LGTM, but this file is in desperate need of type hints and unit tests (leaving for future work)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.