Added minimum waiting time problem solution using greedy algorithm#8701
Merged
cclauss merged 11 commits intoTheAlgorithms:masterfrom May 1, 2023
Merged
Added minimum waiting time problem solution using greedy algorithm#8701cclauss merged 11 commits intoTheAlgorithms:masterfrom
cclauss merged 11 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
the
require type hints
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
bot
added
awaiting reviews
algorithms-keeper
bot
removed
the
require type hints
rohan472000
suggested changes
Apr 30, 2023
amirsoroush
reviewed
Apr 30, 2023
Contributor
amirsoroush
left a comment
amirsoroush
left a comment
There was a problem hiding this comment.
Thank you. I think the code is quite self-explanatory. We can remove those comments. If you decided to change the parameter's type hint, remember to change it in doc string as well.
Contributor
Author
Hi Amir, I have done the suggested changes, you can review them. Thanks! |
amirsoroush
approved these changes
May 1, 2023
Contributor
Author
|
Hello @cclauss , would you kindly review my pull request and merge it? Thank you! |
cclauss
requested changes
May 1, 2023
cclauss
reviewed
May 1, 2023
cclauss
approved these changes
May 1, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
tianyizheng02
pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
…heAlgorithms#8701) * Added minimum waiting time problem solution using greedy algorithm * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ruff --fix * Add type hints * Added two more doc test * Removed unnecessary comments * updated type hints * Updated the code as per the code review --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.