Added rank of matrix in linear algebra by rudransh61 · Pull Request #8687 · TheAlgorithms/Python

rudransh61 · 2023-04-24T11:16:16Z

Hi i am rudransh ,
I added a python file to find rank of matrix because i cannot find it anywhere in code base .
So, i thought that "lets contribute ".
Please try to pull this so that the set of algorithm will be completed.
If there is any error , inform me i will try to correct this.
AND AT LAST I WOULD LIKE TO SAY PLEASE SET IT UP IN A VIRTUAL ENVIRONMENT SO THAT NEW VERSIONS OF REQUIREMENT AND PYTHON WILL NOT AFFECT ANYONE..
THANK YOU FOR READING THIS
A PROGRAMMER
RUDRANSH BHARDWAJ

for more information, see https://pre-commit.ci

rohan472000 · 2023-04-24T18:04:24Z

linear_algebra/src/Rank_of_Matrix.py

+""" BY - RUDRANSH BHARDWAJ"""
+
+
+def swapRows(a, row1, row2):


To resolve ruff errors, you should rename these functions to use lowercase letters. For example, you could rename "swapRows" to "swap_rows", "Row_Transformation" to "row_transformation", and "MatrixRank" to "matrix_rank".

Ok let me try

rohan472000

The error message you received in pre-commit indicates that the file "Rank_of_Matrix.py" contains uppercase characters in its filename, which violates a common naming convention for Python files.

To resolve this error, you should rename the file to use lowercase letters instead. For example, you could rename it to "rank_of_matrix.py" instead.

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-04-25T09:36:15Z

linear_algebra/src/Rank_of_Matrix.py

+""" BY - RUDRANSH BHARDWAJ"""
+
+
+def swap_rows(a, row1, row2):


As there is no test file in this pull request nor any test function or class in the file linear_algebra/src/Rank_of_Matrix.py, please provide doctest for the function swap_rows

Please provide return type hint for the function: swap_rows. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

Please provide type hint for the parameter: row1

Please provide type hint for the parameter: row2

Ok i will try
Thank you

This is a bot, so no need to reply...just do as it suggests

algorithms-keeper · 2023-04-25T09:36:15Z

linear_algebra/src/Rank_of_Matrix.py

+    return a
+
+
+def Row_Transformation(a, x, row1, row2):


As there is no test file in this pull request nor any test function or class in the file linear_algebra/src/Rank_of_Matrix.py, please provide doctest for the function Row_Transformation

Please provide return type hint for the function: Row_Transformation. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: Row_Transformation

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

Please provide descriptive name for the parameter: x

Please provide type hint for the parameter: x

Please provide type hint for the parameter: row1

Please provide type hint for the parameter: row2

algorithms-keeper · 2023-04-25T09:36:15Z

linear_algebra/src/Rank_of_Matrix.py

+    return a
+
+
+def MatrixRank(a):


As there is no test file in this pull request nor any test function or class in the file linear_algebra/src/Rank_of_Matrix.py, please provide doctest for the function MatrixRank

Please provide return type hint for the function: MatrixRank. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: MatrixRank

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2023-04-25T09:39:07Z

linear_algebra/src/Rank_of_Matrix.py

+""" BY - RUDRANSH BHARDWAJ"""
+
+
+def swap_rows(a, row1, row2):


As there is no test file in this pull request nor any test function or class in the file linear_algebra/src/Rank_of_Matrix.py, please provide doctest for the function swap_rows

Please provide return type hint for the function: swap_rows. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

Please provide type hint for the parameter: row1

Please provide type hint for the parameter: row2

algorithms-keeper · 2023-04-25T09:39:07Z

linear_algebra/src/Rank_of_Matrix.py

+    return a
+
+
+def row_transformation(a, x, row1, row2):


As there is no test file in this pull request nor any test function or class in the file linear_algebra/src/Rank_of_Matrix.py, please provide doctest for the function row_transformation

Please provide return type hint for the function: row_transformation. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

Please provide descriptive name for the parameter: x

Please provide type hint for the parameter: x

Please provide type hint for the parameter: row1

Please provide type hint for the parameter: row2

algorithms-keeper · 2023-04-25T09:39:07Z

linear_algebra/src/Rank_of_Matrix.py

+    return a
+
+
+def matrix_rank(a):


As there is no test file in this pull request nor any test function or class in the file linear_algebra/src/Rank_of_Matrix.py, please provide doctest for the function matrix_rank

Please provide return type hint for the function: matrix_rank. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

rohan472000

Kindly rename as I have suggested

rudransh61 · 2023-04-25T10:16:17Z

I want 1 week because i had found some bugs in file
so after some time it will ready for production

rudransh61 · 2023-04-25T10:38:12Z

i had completed all but failing in changing the file name
i you can then please help me to change the name
before pushing it on repository the name was "rank_of_matrix" but after i pushed it into repository idk why it changed into "Rank_of_Matrix" ???

rudransh61 · 2023-04-25T10:38:33Z

now all the errors and naming patterns are corrected except the name

for more information, see https://pre-commit.ci

rohan472000

it should be rank_of_matrix.py because it is a standard practice to write file name in lowercase.

rudransh61 · 2023-04-26T02:03:41Z

finnally after trying for 2hrs i renamed the file

rudransh61 · 2023-04-26T08:00:55Z

doneee

rudransh61 · 2023-04-26T08:01:43Z

and thank you for your feedbacks

rudransh61 · 2023-04-26T11:06:59Z

....is it ok to merge pull request or it is not okay

rudransh61 · 2023-04-28T04:42:56Z

.....can you merge this fork

rohan472000 · 2023-04-28T05:44:04Z

I'm just a contributor, I don't have write access.
Kindly ask @cclauss for a review.

rudransh61 · 2023-04-28T09:55:38Z

how can i ask him for review??

linear_algebra/src/rank_of_matrix.py

cclauss · 2023-04-28T13:08:21Z

linear_algebra/src/rank_of_matrix.py

+    >>> rank_of_matrix([[3,2,1],
+    ...                [-6,-4,-2]])
+    1
+    >>> rank_of_matrix([[],[]])


Please add: >>> rank_of_matrix([[]])

Thanks for your suggestions

I hope this is ready to merge
and thanks to @rohan472000 and @cclauss for their feedbacks and suggestions

Co-authored-by: Christian Clauss <cclauss@me.com>

rudransh61 · 2023-05-01T11:40:40Z

@cclauss please review and merge this (if it is ready)

rudransh61 · 2023-05-22T11:24:52Z

I think now this is okk/?

cclauss · 2023-05-22T11:36:13Z

mypy.....................................................................Failed

hook id: mypy
exit code: 1

linear_algebra/src/rank_of_matrix.py:66: error: No overload variant of "setitem" of "list" matches argument types "int", "float" [call-overload]
linear_algebra/src/rank_of_matrix.py:66: note: Possible overload variants:
linear_algebra/src/rank_of_matrix.py:66: note: def setitem(self, SupportsIndex, int, /) -> None
linear_algebra/src/rank_of_matrix.py:66: note: def setitem(self, slice, Iterable[int], /) -> None
Found 1 error in 1 file (checked 1186 source files)

rudransh61 · 2023-05-29T12:34:26Z

i didnt understand ??? is there any error in code or something else???
I think there is some error while merging ???
or this is something strange ???
please tell me what is this , and what is hook id .....

I dont understand "mypy"

sorry sir for disturbing you but please help meeeeeee??

CaedenPH

@rudransh61 Merge my commit and the checks will pass

linear_algebra/src/rank_of_matrix.py

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

rudransh61

nice
checks are not showing error

rudransh61 · 2023-05-31T11:18:22Z

oooooooooooo Thankakanakankankaaaasssss brooooo

FOR HELPING MEEEEEEEEEEEEEE
NOW 2 CHECKS ARE COMPLETED

you r genius ???? you are pro coderrr @CaedenPH
THANKSSS

rudransh61 · 2023-05-31T11:20:02Z

broooo you aree god

rudransh61 · 2023-05-31T11:32:30Z

I think now it is ready to deploy??

rudransh61 · 2023-05-31T11:32:52Z

Thanks to all reviews and other developers to help mee

cclauss

Let's do this!

rudransh61 and others added 2 commits April 24, 2023 16:41

Added rank of matrix in linear algebra

52ec964

[pre-commit.ci] auto fixes from pre-commit.com hooks

df86e10

for more information, see https://pre-commit.ci

algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Apr 24, 2023

rohan472000 suggested changes Apr 24, 2023

View reviewed changes

Corrected name of function

a1e7bb7

algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Apr 25, 2023

algorithms-keeper bot reviewed Apr 25, 2023

View reviewed changes

Corrected Rank_of_Matrix.py

6cca1cd

algorithms-keeper bot reviewed Apr 25, 2023

View reviewed changes

rohan472000 suggested changes Apr 25, 2023

View reviewed changes

Completed rank_of_matrix.py

cb96700

[pre-commit.ci] auto fixes from pre-commit.com hooks

c027189

for more information, see https://pre-commit.ci

rohan472000 suggested changes Apr 25, 2023

View reviewed changes

rudransh61 added 2 commits April 26, 2023 07:31

delete to rename Rank_of_Matrix.py

d157ec0

created rank_of_matrix

9451960

algorithms-keeper bot removed require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Apr 26, 2023

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Apr 26, 2023

rudransh61 requested a review from rohan472000 April 28, 2023 04:42

Merge branch 'TheAlgorithms:master' into master

9b3fa92

cclauss reviewed Apr 28, 2023

View reviewed changes

linear_algebra/src/rank_of_matrix.py Outdated Show resolved Hide resolved

cclauss reviewed Apr 28, 2023

View reviewed changes

linear_algebra/src/rank_of_matrix.py Outdated Show resolved Hide resolved

cclauss reviewed Apr 28, 2023

View reviewed changes

linear_algebra/src/rank_of_matrix.py Outdated Show resolved Hide resolved

cclauss reviewed Apr 28, 2023

View reviewed changes

rudransh61 and others added 4 commits April 30, 2023 14:30

Update linear_algebra/src/rank_of_matrix.py

afb5191

Co-authored-by: Christian Clauss <cclauss@me.com>

Update linear_algebra/src/rank_of_matrix.py

301726a

Co-authored-by: Christian Clauss <cclauss@me.com>

Update linear_algebra/src/rank_of_matrix.py

e683139

Co-authored-by: Christian Clauss <cclauss@me.com>

Update rank_of_matrix.py

cd8d209

rudransh61 requested a review from cclauss April 30, 2023 09:03

Merge branch 'TheAlgorithms:master' into master

0b13df6

CaedenPH reviewed May 29, 2023

View reviewed changes

linear_algebra/src/rank_of_matrix.py Outdated Show resolved Hide resolved

cclauss and others added 2 commits May 30, 2023 15:06

Update linear_algebra/src/rank_of_matrix.py

8d6caaf

Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>

Merge branch 'TheAlgorithms:master' into master

fc66a5b

rudransh61 commented May 31, 2023

View reviewed changes

cclauss approved these changes May 31, 2023

View reviewed changes

cclauss merged commit e871540 into TheAlgorithms:master May 31, 2023

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks

Uh oh!

Conversation

rudransh61 commented Apr 24, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohan472000 left a comment

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Apr 25, 2023

Choose a reason for hiding this comment

Uh oh!

rohan472000 left a comment

Choose a reason for hiding this comment

Uh oh!

rudransh61 commented Apr 25, 2023

Uh oh!

rudransh61 commented Apr 25, 2023

Uh oh!

rudransh61 commented Apr 25, 2023

Uh oh!

rohan472000 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rudransh61 commented Apr 26, 2023

Uh oh!

rudransh61 commented Apr 26, 2023

Uh oh!

rudransh61 commented Apr 26, 2023

Uh oh!

rudransh61 commented Apr 26, 2023

Uh oh!

rudransh61 commented Apr 28, 2023

Uh oh!

rohan472000 commented Apr 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rudransh61 commented Apr 28, 2023

rohan472000 left a comment •

edited

Loading

rohan472000 commented Apr 28, 2023 •

edited

Loading

CaedenPH left a comment •

edited

Loading

rudransh61 left a comment •

edited

Loading