Reduce the complexity of boolean_algebra/quine_mc_cluskey.py#8604
Merged
tianyizheng02 merged 7 commits intoTheAlgorithms:masterfrom Aug 15, 2023
Conversation
…ey.py' of https://github.com/MaximSmolskiy/Python into reduce-the-complexity-of-boolean_algebra/quine_mc_cluskey.py
algorithms-keeper
bot
added
awaiting reviews
MaximSmolskiy
changed the title
Member
Author
|
@cclauss please review |
cclauss
reviewed
May 28, 2023
cclauss
previously requested changes
Jun 29, 2023
tianyizheng02
requested changes
Aug 13, 2023
Contributor
tianyizheng02
left a comment
tianyizheng02
left a comment
There was a problem hiding this comment.
Your changes look good, and I only have a couple of minor suggestions. However, I noticed a number of issues elsewhere in the code (not related to your changes) that require refactoring and renaming some things. I don't want to hold this PR up, so it's probably best that I address those issues in a later PR.
tianyizheng02
approved these changes
Aug 15, 2023
tianyizheng02
dismissed
cclauss’s stale review
Most review suggestions have already been applied
algorithms-keeper
bot
removed
the
awaiting reviews
MaximSmolskiy
deleted the
reduce-the-complexity-of-boolean_algebra/quine_mc_cluskey.py
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Reduce the complexity of boolean_algebra/quine_mc_cluskey.py from 17 to 13
Checklist:
Fixes: #{$ISSUE_NO}.