Remove extra len calls in doubly-linked-list's methods#8600
Merged
dhruvmanila merged 1 commit intoTheAlgorithms:masterfrom Apr 1, 2023
Merged
Remove extra len calls in doubly-linked-list's methods#8600dhruvmanila merged 1 commit intoTheAlgorithms:masterfrom
len calls in doubly-linked-list's methods#8600dhruvmanila merged 1 commit intoTheAlgorithms:masterfrom
Conversation
len calls in doubly-linked-list's methods
tianyizheng02
pushed a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
I reduced the number of calls to
__len__by storing the result into a local variable as it's currently a costly method( O(N) ).To elaborate more: Suppose we insert an item at the tail like:
The second call to
insert_at_tailcauses__len__to be called three times:self.insert_at_nth(len(self), data)(because of delegating toinsert_at_nth)if not 0 <= index <= len(self)insideinsert_at_nthelif index == len(self)insideinsert_at_nthSame thing happens in
delete_at_nth.Checklist:
Fixes: #{$ISSUE_NO}.