Conversation
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
physics/grahams_law.py
Outdated
| from math import pow, sqrt | ||
|
|
||
|
|
||
| def validate(*values) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file physics/grahams_law.py, please provide doctest for the function validate
Please provide type hint for the parameter: values
algorithms-keeper
bot
added
tests are failing
algorithms-keeper
bot
removed
the
tests are failing
| -------- | ||
| >>> validate(2.016, 4.002) | ||
| True | ||
| >>> validate(-2.016, 4.002) |
There was a problem hiding this comment.
Please add a test for
>>> validate(2.016, -4.002)
and explain why it returns the wrong result.
Python's builtin all() or any() might be a better fit.
There was a problem hiding this comment.
Hello @cclauss thank you for your feedback. I just pushed up changes to address this test case. I also added value errors to explain why this test returns False
algorithms-keeper
bot
removed
the
awaiting reviews
* grahams law * doctest and type hints * doctest formatting * peer review updates
2 participants
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.