Fix mypy errors in lu_decomposition.py (attempt 2)#8100
Merged
cclauss merged 13 commits intoTheAlgorithms:masterfrom Apr 1, 2023
Merged
Fix mypy errors in lu_decomposition.py (attempt 2)#8100cclauss merged 13 commits intoTheAlgorithms:masterfrom
mypy errors in lu_decomposition.py (attempt 2)#8100cclauss merged 13 commits intoTheAlgorithms:masterfrom
Conversation
Add an explanation of LU decomposition with conditions for when an LU decomposition exists Add extra doctests to handle each of the possible conditions for when a decomposition exists/doesn't exist
algorithms-keeper
bot
added
enhancement
tianyizheng02
changed the title
mypy errors in lu_decomposition.pymypy errors in lu_decomposition.py (attempt 2)
Contributor
Author
|
@cclauss mind taking a look? |
CaedenPH
approved these changes
Feb 6, 2023
Contributor
CaedenPH
left a comment
CaedenPH
left a comment
There was a problem hiding this comment.
Seems like good changes to me
Contributor
Author
|
@cclauss Not sure why this still has the "tests are failing" label since it looks like all checks passed. Either way, does this look good to be merged? |
cclauss
approved these changes
Apr 1, 2023
tianyizheng02
added a commit
to tianyizheng02/Python
that referenced
this pull request
May 29, 2023
…#8100) * updating DIRECTORY.md * Fix mypy errors in lu_decomposition.py * Replace for-loops with comprehensions * Add explanation of LU decomposition and extra doctests Add an explanation of LU decomposition with conditions for when an LU decomposition exists Add extra doctests to handle each of the possible conditions for when a decomposition exists/doesn't exist * updating DIRECTORY.md * updating DIRECTORY.md --------- Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
lu_decomposition.pyto resolvemypyerrors (seemypyproduces errors when run on its own #8070)Attempt 2 of making a PR since the first one (#8076) was closed due to having too many PRs open at a time.
Checklist:
Fixes: #{$ISSUE_NO}.