Remove a slash in path to save the file correctly on Linux#8053
Merged
cclauss merged 1 commit intoTheAlgorithms:masterfrom Aug 15, 2023
Erfaniaa:patch-6
Merged
Remove a slash in path to save the file correctly on Linux#8053cclauss merged 1 commit intoTheAlgorithms:masterfrom Erfaniaa:patch-6
cclauss merged 1 commit intoTheAlgorithms:masterfrom
Erfaniaa:patch-6
Conversation
algorithms-keeper
bot
added
awaiting reviews
CaedenPH
approved these changes
Dec 27, 2022
Contributor
CaedenPH
left a comment
CaedenPH
left a comment
There was a problem hiding this comment.
Looks good - Great spot
CaedenPH
approved these changes
Dec 27, 2022
Contributor
CaedenPH
left a comment
CaedenPH
left a comment
There was a problem hiding this comment.
Looks good - Great spot
itsamirhn
reviewed
Dec 27, 2022
| @@ -32,13 +32,13 @@ def main() -> None: | |||
| letter_code = random_chars(32) | |||
| file_name = paths[index].split(os.sep)[-1].rsplit(".", 1)[0] | |||
| file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}" | |||
Member
There was a problem hiding this comment.
Suggested change
| file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}" | |
| file_root = os.path.join(OUTPUT_DIR, f"{file_name}_FLIP_{letter_code}") |
Contributor
There was a problem hiding this comment.
Suggested change
| file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}" | |
| file_root = Path(OUTPUT_DIR, f"{file_name}_FLIP_{letter_code}") |
tianyizheng02
previously requested changes
Aug 13, 2023
| @@ -32,13 +32,13 @@ def main() -> None: | |||
| letter_code = random_chars(32) | |||
| file_name = paths[index].split(os.sep)[-1].rsplit(".", 1)[0] | |||
| file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| file_root = f"{OUTPUT_DIR}/{file_name}_FLIP_{letter_code}" | |
| file_root = Path(OUTPUT_DIR, f"{file_name}_FLIP_{letter_code}") |
cclauss
approved these changes
Aug 15, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.