Texture analysis using Haralick Descriptors for Computer Vision tasks by rzimmerdev · Pull Request #8004 · TheAlgorithms/Python

rzimmerdev · 2022-11-27T16:49:06Z

Describe your change:

I've added a series of methods for calculating the Haralick descriptors, as well as some encapsulating methods for comparing textures between a baseline image and a sequence of comparison images.

Add an algorithm?

Checklist:

for more information, see https://pre-commit.ci

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-11-27T16:55:04Z

computer_vision/haralick_descriptors.py

+
+
+def normalize_image(
+    image: np.ndarray, cap: float = 255.0, data_type=np.uint8


Please provide type hint for the parameter: data_type

algorithms-keeper · 2022-11-27T16:55:04Z

computer_vision/haralick_descriptors.py

+    return np.where(image > threshold, 1, 0)
+
+
+def transform(image: np.ndarray, kind: str, kernel=None) -> np.ndarray:


Please provide type hint for the parameter: kernel

algorithms-keeper · 2022-11-27T16:55:05Z

computer_vision/haralick_descriptors.py

+    return true_mask, false_mask
+
+
+def matrix_concurrency(image: np.ndarray, coordinate) -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file computer_vision/haralick_descriptors.py, please provide doctest for the function matrix_concurrency

Please provide type hint for the parameter: coordinate

algorithms-keeper · 2022-11-27T16:55:05Z

computer_vision/haralick_descriptors.py

+    return matrix / np.sum(matrix)
+
+
+def haralick_descriptors(matrix: np.ndarray) -> list:


As there is no test file in this pull request nor any test function or class in the file computer_vision/haralick_descriptors.py, please provide doctest for the function haralick_descriptors

algorithms-keeper · 2022-11-27T16:55:05Z

computer_vision/haralick_descriptors.py

+    ]
+
+
+def get_descriptors(masks: tuple[np.ndarray, np.ndarray], coordinate) -> np.ndarray:


As there is no test file in this pull request nor any test function or class in the file computer_vision/haralick_descriptors.py, please provide doctest for the function get_descriptors

Please provide type hint for the parameter: coordinate

algorithms-keeper · 2022-11-27T16:55:05Z

computer_vision/haralick_descriptors.py

+    return np.sqrt(np.sum(np.square(point_1 - point_2)))
+
+
+def get_distances(descriptors, base) -> list[Any]:


As there is no test file in this pull request nor any test function or class in the file computer_vision/haralick_descriptors.py, please provide doctest for the function get_distances

Please provide type hint for the parameter: descriptors

Please provide type hint for the parameter: base

algorithms-keeper · 2022-11-27T16:55:05Z

computer_vision/haralick_descriptors.py

+    return sorted(enumerate(distances), key=lambda tup: tup[1])
+
+
+def main():


Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/haralick_descriptors.py, please provide doctest for the function main

algorithms-keeper

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

algorithms-keeper · 2022-11-27T17:22:08Z

computer_vision/haralick_descriptors.py

+    return sorted(enumerate(distances), key=lambda tup: tup[1])
+
+
+def main():


Please provide return type hint for the function: main. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file computer_vision/haralick_descriptors.py, please provide doctest for the function main

rzimmerdev · 2022-11-27T17:22:49Z

Does the main require a doctest as well? gezz...

for more information, see https://pre-commit.ci

rzimmerdev · 2022-11-29T00:52:51Z

@cclauss Awaiting review 😁

rzimmerdev · 2022-12-06T23:18:01Z

@cclauss Any insights yet?

CaedenPH

Sorry for the delay - Pr looks good to me, awesome work!
@cclauss Could you review please

cclauss · 2022-12-08T20:13:00Z

requirements.txt

@@ -1,5 +1,6 @@
 beautifulsoup4
 fake_useragent
+imageio


Let's make sure that imageio/imageio#916 is merged.

Depending on how you plan to use ImageIO, I'd recommend using imageio<3.0 or imageio<4.0 instead. We will release v3.0 around the end of January which will remove deprecations. Pinning up to the next version major avoids your code breaking once that happens and puts you in charge of when/how to upgrade.

We are a bit different than most repos. In general, we do not pin dependencies because we are not shipping an executable (app or library) and our individual algorithms are almost always self-standing. We hope that tests catch incompatibilities so that they can be fixed as they break. If not then users can report failures so we fix-as-we-go.

computer_vision/haralick_descriptors.py

No! What if the Kernel is empty? Example: >>> kernel = np.zeros((1)) >>> kernel or np.ones((3, 3)) array([[1., 1., 1.], [1., 1., 1.], [1., 1., 1.]]) Co-authored-by: Christian Clauss <cclauss@me.com>

cclauss · 2022-12-18T23:15:49Z

Please rebase on the current master

rzimmerdev · 2022-12-20T02:04:18Z

Awaiting merge :)

tianyizheng02 · 2023-08-13T21:34:54Z

computer_vision/haralick_descriptors.py

+        array([[158,  97],
+               [ 56, 200]], dtype=uint8)
+    """
+    return np.dot(image[:, :, 0:3], [0.299, 0.587, 0.114]).astype(np.uint8)


Can you include a source (e.g., Wikipedia) for those luminance weight values?

tianyizheng02 · 2023-08-13T21:38:23Z

computer_vision/haralick_descriptors.py

+def transform(image: np.ndarray, kind: str, kernel: np.ndarray = None) -> np.ndarray:
+    """
+    Simple image transformation using one of two available filter functions:
+    Erosion and Dilation.


We already have digital_image_processing/morphological_operations/erosion_operation.py and digital_image_processing/morphological_operations/dilation_operation.py. Can we use those two files to replace this function in the future?

computer_vision/haralick_descriptors.py

tianyizheng02 · 2023-08-13T21:55:08Z

computer_vision/haralick_descriptors.py

+    index = int(input())
+    q_value = [int(value) for value in input().split()]
+
+    # Format is the respective filter to apply,
+    # can be either 1 for the opening filter or else for the closing
+    parameters = {"format": int(input()), "threshold": int(input())}
+
+    # Number of images to perform methods on
+    b_number = int(input())
+
+    files, descriptors = ([], [])
+
+    for _ in range(b_number):
+        file = input().rstrip()


Can we have prompt messages for each of the input calls

computer_vision/haralick_descriptors.py

for more information, see https://pre-commit.ci

tianyizheng02

There are still some minor issues, but the major ones have been addressed.

rzimmerdev and others added 5 commits October 18, 2022 22:01

Create haralick_descriptors

802cd20

Working on creating Unit Testing for Haralick Descriptors module

88b014f

Type hinting for Haralick descriptors

bc6a189

Merge branch 'TheAlgorithms:master' into master

dff5498

Fixed docstrings, unit testing and formatting choices

6e23cc0

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Nov 27, 2022

[pre-commit.ci] auto fixes from pre-commit.com hooks

eca7118

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 27, 2022

rzimmerdev added 2 commits November 27, 2022 13:54

Fixed line size formatting

9d2cca7

Merge remote-tracking branch 'origin/master'

cd250cf

algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Nov 27, 2022

algorithms-keeper bot reviewed Nov 27, 2022

View reviewed changes

Added final doctests

5e73aa6

algorithms-keeper bot reviewed Nov 27, 2022

View reviewed changes

Changed main callable

aacb27e

algorithms-keeper bot removed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Nov 27, 2022

rzimmerdev and others added 2 commits November 27, 2022 14:29

Updated requirements.txt

5fb933d

[pre-commit.ci] auto fixes from pre-commit.com hooks

c9ec63e

for more information, see https://pre-commit.ci

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 27, 2022

CaedenPH approved these changes Dec 8, 2022

View reviewed changes

cclauss reviewed Dec 8, 2022

View reviewed changes

cclauss reviewed Dec 10, 2022

View reviewed changes

computer_vision/haralick_descriptors.py Outdated Show resolved Hide resolved

rzimmerdev and others added 2 commits December 13, 2022 17:51

Update computer_vision/haralick_descriptors.py

bfd0fd7

No! What if the Kernel is empty? Example: >>> kernel = np.zeros((1)) >>> kernel or np.ones((3, 3)) array([[1., 1., 1.], [1., 1., 1.], [1., 1., 1.]]) Co-authored-by: Christian Clauss <cclauss@me.com>

Undone wrong commit

6f52bff

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Dec 13, 2022

Merge branch 'TheAlgorithms:master' into master

ca90e9a

algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 19, 2022

rzimmerdev added 2 commits December 19, 2022 22:42

Merge branch 'TheAlgorithms:master' into master

408b0fb

Update haralick_descriptors.py

fc2fa0b

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 20, 2022

rzimmerdev requested review from CaedenPH and cclauss and removed request for cclauss December 20, 2022 03:31

tianyizheng02 mentioned this pull request Aug 13, 2023

Deblur and Denoise using Richardson Lucy Deconvolution for Computer Vision tasks #8038

Closed

12 tasks

tianyizheng02 requested changes Aug 13, 2023

View reviewed changes

tianyizheng02 requested changes Sep 5, 2023

View reviewed changes

tianyizheng02 and others added 2 commits September 4, 2023 23:12

Apply suggestions from code review

40da555

[pre-commit.ci] auto fixes from pre-commit.com hooks

ba2f474

for more information, see https://pre-commit.ci

algorithms-keeper bot added the tests are failing Do not merge until tests pass label Sep 5, 2023

tianyizheng02 added 6 commits September 4, 2023 23:19

Fix ruff errors in haralick_descriptors.py

9faef36

Add type hint to haralick_descriptors.py to fix ruff error

7eda2b8

Update haralick_descriptors.py

fd085df

Update haralick_descriptors.py

40daa68

Update haralick_descriptors.py

8da35eb

Update haralick_descriptors.py

5795fc4

algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Sep 5, 2023

tianyizheng02 added 3 commits September 4, 2023 23:48

Try to fix mypy errors in haralick_descriptors.py

44d6bd1

Update haralick_descriptors.py

21efc62

Fix type hint in haralick_descriptors.py

5fa7520

tianyizheng02 approved these changes Sep 5, 2023

View reviewed changes

tianyizheng02 merged commit 79b043d into TheAlgorithms:master Sep 5, 2023

algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Sep 5, 2023

isidroas mentioned this pull request Jan 25, 2025

dh isidroas/Python#1

Closed

14 tasks



		def normalize_image(
		image: np.ndarray, cap: float = 255.0, data_type=np.uint8

		return np.where(image > threshold, 1, 0)


		def transform(image: np.ndarray, kind: str, kernel=None) -> np.ndarray:

		return true_mask, false_mask


		def matrix_concurrency(image: np.ndarray, coordinate) -> np.ndarray:

		return matrix / np.sum(matrix)


		def haralick_descriptors(matrix: np.ndarray) -> list:

		]


		def get_descriptors(masks: tuple[np.ndarray, np.ndarray], coordinate) -> np.ndarray:

		return np.sqrt(np.sum(np.square(point_1 - point_2)))


		def get_distances(descriptors, base) -> list[Any]:

		return sorted(enumerate(distances), key=lambda tup: tup[1])


		def main():

Uh oh!

Conversation

rzimmerdev commented Nov 27, 2022

Describe your change:

Checklist:

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

algorithms-keeper bot left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

algorithms-keeper bot Nov 27, 2022

Choose a reason for hiding this comment

Uh oh!

rzimmerdev commented Nov 27, 2022

Uh oh!

rzimmerdev commented Nov 29, 2022

Uh oh!

rzimmerdev commented Dec 6, 2022

Uh oh!

CaedenPH left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

FirefoxMetzger Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

cclauss Dec 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cclauss commented Dec 18, 2022

Uh oh!

rzimmerdev commented Dec 20, 2022

Uh oh!

tianyizheng02 Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

tianyizheng02 Aug 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!