Added Continued fractions#6846
Merged
tianyizheng02 merged 6 commits intoTheAlgorithms:masterfrom Aug 16, 2023
Merged
Conversation
14 tasks
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
github-actions
bot
force-pushed
the
continuous-fractions
branch
from
504a0fd to
e18b2fe
Compare
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
tianyizheng02
approved these changes
Aug 16, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
cclauss
reviewed
Aug 16, 2023
| >>> continued_fraction(1/Fraction("2.25")) | ||
| [0, 2, 4] | ||
| >>> continued_fraction(Fraction("415/93")) | ||
| [4, 2, 6, 7] |
Member
There was a problem hiding this comment.
Needs tests for 0 and for negative numbers.
Contributor
There was a problem hiding this comment.
Added tests for 0 and negative numbers in #8985
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
added a function to convert a rational number to continued fraction list
Checklist:
Fixes: #{$ISSUE_NO}.