Add Project Euler problem 082 solution 1#6282
Merged
dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom Mar 2, 2023
Merged
Add Project Euler problem 082 solution 1#6282dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom
dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom
Conversation
ghost
added
awaiting reviews
…thub.com/MaximSmolskiy/Python into add-project-euler-problem-082-solution-1
ghost
mentioned this pull request
14 tasks
Member
Author
|
@cclauss @dhruvmanila please review |
Member
Author
|
@dhruvmanila please review |
1 similar comment
Member
Author
|
@dhruvmanila please review |
Member
Author
|
@dhruvmanila please review |
dhruvmanila
requested changes
Mar 1, 2023
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Few minor nitpicks and it's good to go! Thanks for your patience!
project_euler/problem_082/sol1.py
Outdated
| import os | ||
|
|
||
|
|
||
| def solution(filename: str = "p082_matrix.txt") -> int: |
Member
There was a problem hiding this comment.
Suggested change
| def solution(filename: str = "p082_matrix.txt") -> int: | |
| def solution(filename: str = "input.txt") -> int: |
Simple name is better, we're already in the problem directory
project_euler/problem_082/sol1.py
Outdated
Comment on lines
40
to
41
| m = len(matrix) | ||
| n = len(matrix[0]) |
Member
There was a problem hiding this comment.
Suggested change
| m = len(matrix) | |
| n = len(matrix[0]) | |
| rows = len(matrix) | |
| cols = len(matrix[0]) |
I think this would be better for posterity. Please update wherever else is required.
algorithms-keeper
bot
added
awaiting changes
algorithms-keeper
bot
added
awaiting reviews
MaximSmolskiy
requested review from
dhruvmanila
and removed request for
Kush1101
dhruvmanila
approved these changes
Mar 2, 2023
algorithms-keeper
bot
removed
the
awaiting reviews
Cjkjvfnby
pushed a commit
to Cjkjvfnby/Python
that referenced
this pull request
Mar 13, 2023
Update DIRECTORY.md
---------
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Add Project Euler problem 082 solution 1:
Checklist:
Fixes: #{$ISSUE_NO}.