Unify primality checking#6228
Merged
poyea merged 4 commits intoTheAlgorithms:masterfrom Jul 11, 2022
ngiachou:unify-primality-checking
Merged
Unify primality checking#6228poyea merged 4 commits intoTheAlgorithms:masterfrom ngiachou:unify-primality-checking
poyea merged 4 commits intoTheAlgorithms:masterfrom
ngiachou:unify-primality-checking
Conversation
Contributor
Author
|
I think I have done something wrong with my commit history... Is there a way of fixing this? |
Contributor
Author
Nevermind, fixed it! |
14 tasks
poyea
approved these changes
Jul 11, 2022
Member
poyea
left a comment
There was a problem hiding this comment.
Thank you for your pull request!🤩
Member
|
It would be great if we can check against also the project_euler files. Let's merge this and have the updates in #5434 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
I refactored some functions in order to fix #5434. More specifically,
O(sqrt(n))time complexity algorithm.There are some more functions that are related to primality checking namely the lucas_lehmer_primality_test.py and miller_rabin.py but I did not change these since they are specific algorithms.
I have searched for every mention of the word
primein all of the files and except from the project_euler I think that there are no other mentions on the primality testing subject.Checklist:
Fixes: #{$ISSUE_NO}.