Fixes recursion exception in davisb_putnamb_logemann_loveland#5647
Closed
spazm wants to merge 6 commits intoTheAlgorithms:masterfrom
Closed
Fixes recursion exception in davisb_putnamb_logemann_loveland#5647spazm wants to merge 6 commits intoTheAlgorithms:masterfrom
spazm wants to merge 6 commits intoTheAlgorithms:masterfrom
Conversation
The formula {{A3' , A1} , {A3} , {A4}} is satisfiable with the
assignment {'A1': True, 'A4': True, 'A3': True}.
The formula {{A3' , A1} , {A4} , {A3}} is raises a RecursionError and is
not satisfiable.
The formula {{A2' , A3} , {A2 , A3 , A5' , A1} , {A3} , {A5 , A1'}} is
raises a RecursionError and is
not satisfiable.
+ copies model to allow independent mutation. + python assigns by reference. both tmp models mutated the original model and the second over wrote the first. Recursion was going down the same branch each time.
…nevaluated symbols
+ filter out P during the copy rather than removing after the copy is both clearer and marginally more efficient. 1.5n -> n
ghost
added
awaiting reviews
This was referenced Oct 28, 2021
Member
|
|
l3str4nge
requested changes
Oct 30, 2021
| print(f"satisfiable with the assignment {model}.") | ||
| else: | ||
| print("not satisfiable.") | ||
| # recursion example: |
Member
There was a problem hiding this comment.
I would remove this block of code
| {'A4': True} | ||
| """ | ||
|
|
||
| # 2. Check any False |
ghost
added
awaiting changes
14 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.