Reduced Time Complexity#5236
Closed
abhijitgawai wants to merge 1 commit intoTheAlgorithms:masterfrom
abhijitgawai:abhi_string
Closed
Reduced Time Complexity#5236abhijitgawai wants to merge 1 commit intoTheAlgorithms:masterfrom abhijitgawai:abhi_string
abhijitgawai wants to merge 1 commit intoTheAlgorithms:masterfrom
abhijitgawai:abhi_string
Conversation
cclauss
reviewed
Oct 11, 2021
Comment on lines
+18
to
+21
| if len(first_str)==0: | ||
| return second_str | ||
| if len(second_str)==0: | ||
| return first_str |
Member
There was a problem hiding this comment.
Suggested change
| if len(first_str)==0: | |
| return second_str | |
| if len(second_str)==0: | |
| return first_str | |
| if not first_str or not second_str: | |
| return first_str and second_str |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
1st :-
Added Base Condition to Reduce Time Complexity
2nd :-
Previously Time Complexity was O( max( len(first_str) , len(second_str) ) )
So, now on line 26, I am considering minimum length of both string.
Select alternate characters of both strings. For
max( len(first_str) , len(second_str) )times and exitforloopThen Concatenate remaining characters of larger string. <- This does not require for loop, Thus reducing Time Complexity.
Now Time Complexity is
O( min ( len(first_str) , len(second_str) ) )Checklist:
Fixes: #{$ISSUE_NO}.