Electric power by erdum · Pull Request #3976 · TheAlgorithms/Python

erdum · 2020-11-27T21:47:35Z

Describe your change:

Used code from ohms_law algorithm, but now for power calculation

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

erdum · 2020-11-27T21:49:36Z

@cclauss hello, sir please debug it and give me some tips and instructions, some lines in code are longer then 79 so what should i need to do????

cclauss · 2020-11-27T22:02:53Z

Maximum line length is 88 characters.

electronics/electric_power.py

cclauss · 2020-11-27T22:11:43Z

electronics/electric_power.py

+        result = (float(voltage * current))
+        if result < 0:
+            result = result * -1
+        return {'power': result}


Please use the builtin function abs()
https://docs.python.org/3/library/functions.html#abs

erdum · 2020-11-28T08:50:17Z

@cclauss all done sir.

cclauss

Let's spice up the tests and let's return a namedtuple instead of a dict. Namedtuples are more optimized than dicts and they provides helpful names.

cclauss · 2020-11-28T09:15:26Z

electronics/electric_power.py

+    >>> electric_power(voltage=2, current=2, power=0)
+    {'power': 4.0}
+    >>> electric_power(voltage=-2, current=3, power=0)
+    {'power': 6.0}


Need to test:

No zeros

Two zeros

Negative numbers for power

Floating-point numbers

Suggested change

{'power': 6.0}

>>> electric_power(voltage=-2, current=3, power=0).name

'power'

>>> electric_power(voltage=-2, current=3, power=0).value

6.0

Okay, should i also do this on ohms_law as well??

Let's get this PR landed before you modify Ohm's law...

Coincidentally, @rhettinger (who wrote the namedtuple) just tweeted about Ohm's law...
https://twitter.com/raymondh/status/1331850115674345473

cclauss · 2020-11-28T09:17:50Z

electronics/electric_power.py

@@ -0,0 +1,33 @@
+# https://en.m.wikipedia.org/wiki/Electric_power
+


Suggested change

from collections import namedtuple

result = namedtuple("result", "name value")

cclauss · 2020-11-28T09:21:36Z

electronics/electric_power.py

+    fundamental value of electrical system.
+    examples are below:
+    >>> electric_power(voltage=0, current=2, power=5)
+    {'voltage': 2.5}


Suggested change

{'voltage': 2.5}

result(name='voltage', value=2.5)

cclauss · 2020-11-28T09:22:23Z

electronics/electric_power.py

+            "Power cannot be negative in any electrical/electronics system"
+        )
+    elif voltage == 0:
+        return {"voltage": power / current}


Suggested change

return {"voltage": power / current}

return result("voltage", power / current)

erdum · 2020-11-29T19:38:31Z

@cclauss sir run this code and you will see that with floating point values it will give you very long decimal value output, so my question is how to wrapped it, to only for 3 values after decimal point

erdum · 2020-11-29T19:52:07Z

@cclauss I figured out, now all done???

cclauss

Nice!

* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done

Electric power

4d05e13

ghost added the awaiting reviews This PR is ready to be reviewed label Nov 27, 2020

ghost added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Nov 27, 2020

cclauss reviewed Nov 27, 2020

View reviewed changes

electronics/electric_power.py Outdated Show resolved Hide resolved

cclauss reviewed Nov 27, 2020

View reviewed changes

electronics/electric_power.py Outdated Show resolved Hide resolved

cclauss reviewed Nov 27, 2020

View reviewed changes

erdum added 2 commits November 28, 2020 13:41

updated as suggested by cclauss

9b2826e

updated as suggested by cclauss

ef4bccd

ghost added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Nov 28, 2020

cclauss requested changes Nov 28, 2020

View reviewed changes

ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Nov 28, 2020

decimal value error

cded249

ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Nov 29, 2020

ghost added tests are failing Do not merge until tests pass and removed awaiting reviews This PR is ready to be reviewed labels Nov 29, 2020

All done

fb2b100

ghost added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Nov 29, 2020

erdum requested a review from cclauss November 29, 2020 20:04

cclauss approved these changes Nov 29, 2020

View reviewed changes

cclauss merged commit daceb87 into TheAlgorithms:master Nov 29, 2020

ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 29, 2020

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021

Electric power (TheAlgorithms#3976)

acf1bf3

* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done

peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021

Electric power (TheAlgorithms#3976)

08228ec

* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done

Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021

Electric power (TheAlgorithms#3976)

ecc0050

* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done

shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021

Electric power (TheAlgorithms#3976)

ccce753

* Electric power * updated as suggested by cclauss * updated as suggested by cclauss * decimal value error * All done

-    {'power': 6.0}
+    >>> electric_power(voltage=-2, current=3, power=0).name
+    'power'
+    >>> electric_power(voltage=-2, current=3, power=0).value
+.0

		@@ -0,0 +1,33 @@
		# https://en.m.wikipedia.org/wiki/Electric_power



	from collections import namedtuple

	result = namedtuple("result", "name value")

	return {"voltage": power / current}
	return result("voltage", power / current)

Uh oh!

Conversation

erdum commented Nov 27, 2020

Describe your change:

Checklist:

Uh oh!

erdum commented Nov 27, 2020

Uh oh!

cclauss commented Nov 27, 2020

Uh oh!

Uh oh!

Uh oh!

cclauss Nov 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erdum Nov 28, 2020

Choose a reason for hiding this comment

Uh oh!

erdum commented Nov 28, 2020

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss Nov 28, 2020

Choose a reason for hiding this comment

Uh oh!

erdum Nov 28, 2020

Choose a reason for hiding this comment

Uh oh!

cclauss Nov 28, 2020

Choose a reason for hiding this comment

Uh oh!

cclauss Nov 28, 2020

Choose a reason for hiding this comment

Uh oh!

cclauss Nov 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss Nov 28, 2020

Choose a reason for hiding this comment

Uh oh!

erdum commented Nov 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erdum commented Nov 29, 2020

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cclauss Nov 27, 2020 •

edited

Loading

cclauss Nov 28, 2020 •

edited

Loading

erdum commented Nov 29, 2020 •

edited

Loading