Hacktoberfest 2020 - Add typehints and default input for project_euler/problem_25#2901
Merged
dhruvmanila merged 8 commits intoTheAlgorithms:masterfrom Oct 7, 2020
nstoik:master
Merged
Hacktoberfest 2020 - Add typehints and default input for project_euler/problem_25#2901dhruvmanila merged 8 commits intoTheAlgorithms:masterfrom nstoik:master
dhruvmanila merged 8 commits intoTheAlgorithms:masterfrom
nstoik:master
Conversation
Contributor
Author
|
This PR addresses the issues mentioned in #2786(comment) in the directory for Project Euler Problem 25 I have a couple of things I want to confirm for this pull request. For sol1.py are the added docstrings to the functions good or is it redundant? And is it okay to edit the provided solution as well? I removed the check for int since the typehint now specifies it should be an int. And for sol3.py I removed the unused variable to get rid of that warning. I am happy to make any edits to the pull request as needed! |
Kush1101
reviewed
Oct 6, 2020
dhruvmanila
reviewed
Oct 6, 2020
dhruvmanila
added
awaiting changes
dhruvmanila
approved these changes
Oct 7, 2020
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…rithms#2901) * add typehints and docstrings * add typehint and default value * add typehint and default value. Removed unused variable. * do not modifiy the given solution * add doctests * update sol1 after running black * add typehint, docstring, and doctest * update sol2 after running black
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…rithms#2901) * add typehints and docstrings * add typehint and default value * add typehint and default value. Removed unused variable. * do not modifiy the given solution * add doctests * update sol1 after running black * add typehint, docstring, and doctest * update sol2 after running black
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.Related: #2786