math/extended_euclidean_algorithm: add doctests and support for negative numbers#2626
Merged
dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom Oct 7, 2020
pikulet:math-extended-euclid
Merged
math/extended_euclidean_algorithm: add doctests and support for negative numbers#2626dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom pikulet:math-extended-euclid
dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom
pikulet:math-extended-euclid
Conversation
pikulet
changed the title
Member
|
As mentioned in #2630, can you make the appropriate changes for the algorithm to handle negative numbers? |
pikulet
changed the title
Contributor
Author
|
done. resolves #2630 |
dhruvmanila
reviewed
Oct 5, 2020
dhruvmanila
reviewed
Oct 5, 2020
dhruvmanila
requested changes
Oct 7, 2020
dhruvmanila
approved these changes
Oct 7, 2020
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…rs (TheAlgorithms#2626) * add type hints to math/extended euclid * math/extended euclid - add doctest * math/extended euclid: remove manual doctest * change algorithm for negative numbers * improve naming of variables * Update extended_euclidean_algorithm.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
…rs (TheAlgorithms#2626) * add type hints to math/extended euclid * math/extended euclid - add doctest * math/extended euclid: remove manual doctest * change algorithm for negative numbers * improve naming of variables * Update extended_euclidean_algorithm.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.