Added strand sort#1981
Closed
l3str4nge wants to merge 23 commits intoTheAlgorithms:masterfrom
l3str4nge:master
Closed
Added strand sort#1981l3str4nge wants to merge 23 commits intoTheAlgorithms:masterfrom l3str4nge:master
l3str4nge wants to merge 23 commits intoTheAlgorithms:masterfrom
l3str4nge:master
Conversation
Co-Authored-By: Christian Clauss <cclauss@me.com>
Co-Authored-By: Christian Clauss <cclauss@me.com>
Co-Authored-By: Christian Clauss <cclauss@me.com>
Member
Author
|
23 commits o.O I will reopen this PR. |
cclauss
reviewed
May 14, 2020
| import operator | ||
|
|
||
|
|
||
| def strand_sort(arr: list, solution: list, _operator: callable): |
Member
There was a problem hiding this comment.
This sort would be easier to use (and test) if it returned a list instead of requiring the caller to allocate and pass in a solution list.
Member
There was a problem hiding this comment.
It would also be cool if _operator was an optional parameter with the default set to operator.gt.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
I didn't find strand sort (https://en.wikipedia.org/wiki/Strand_sort) implemenation so here it is.
Checklist:
Fixes: #{$ISSUE_NO}.