Skip to content

Comments

Create number_of_digits.py#1975

Merged
cclauss merged 5 commits intoTheAlgorithms:masterfrom
vicky1999:patch-1
Jun 1, 2020
Merged

Create number_of_digits.py#1975
cclauss merged 5 commits intoTheAlgorithms:masterfrom
vicky1999:patch-1

Conversation

@vicky1999
Copy link
Contributor

@vicky1999 vicky1999 commented May 13, 2020 •
edited by cclauss
Loading

A Python program to find the number of digits in a number.

@vicky1999
Copy link
Contributor Author

vicky1999 commented May 13, 2020

I have created and edited the number_of_digits.py but the file build failed due to an error in resize.py

1 file would be reformatted, 561 files would be left unchanged.
before_script.2
0.00s$ IGNORE=E123,E203,E265,E266,E302,E401,E402,E712,E731,E741,E743,F811,F841,W291,W293,W503
8.97s$ flake8 . --count --ignore=$IGNORE --max-complexity=25 --max-line-length=127 --show-source --statistics
./digital_image_processing/resize/resize.py:14:30: F541 f-string is missing placeholders
raise ValueError(f"Destination width/height should be > 0")
^
1 F541 f-string is missing placeholders
1
The command "flake8 . --count --ignore=$IGNORE --max-complexity=25 --max-line-length=127 --show-source --statistics" failed and exited with 1 during .
Your build has been stopped.

@Ankuraxz Ankuraxz mentioned this pull request May 13, 2020
Closed
14 tasks
cclauss
cclauss approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks.

@cclauss cclauss merged commit dc720a8 into TheAlgorithms:master Jun 1, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@vicky1999 @cclauss @stokhos
Create number_of_digits.py (TheAlgorithms#1975)
e402489 
* Create number_of_digits.py

A python program to find the number of digits in a number.

* Update number_of_digits.py

* Update number_of_digits.py

* Add TheAlgorithms#1976 to get Travis CI to pass

TheAlgorithms#1976

* Add type hints as discussed in CONTRIBUTING.md

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

+1 more reviewer

@swapnanildutta swapnanildutta swapnanildutta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicky1999 @cclauss @swapnanildutta