Update longest_increasing_subsequence.py#12499
Closed
squenson1 wants to merge 1 commit intoTheAlgorithms:masterfrom
Closed
Update longest_increasing_subsequence.py#12499squenson1 wants to merge 1 commit intoTheAlgorithms:masterfrom
squenson1 wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
Counter-example that doesn't return the longest increasing subsequence
Member
|
@squenson1 Thanks for counter-example. In future, please create issues for such problems (as I created #12510) - not pull requests. Additionally, I found a problem in current doctest Correct answers could be I am closing this pull request - feel free to fix current incorrect implementation and create corresponding pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counter-example that doesn't return the longest increasing subsequence
Describe your change:
The algorithm longest_increasing_subsequence.py has a bug for the sequence [28, 26, 12, 23, 35, 39] as it returns [26, 35, 39] instead of [12, 23, 35, 39]. (No change in code has been done).
Checklist: