Doomsday Algorithm: Fix leap year check#12396
Merged
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom Jan 18, 2025
Merged
Doomsday Algorithm: Fix leap year check#12396tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
tianyizheng02 merged 4 commits intoTheAlgorithms:masterfrom
Conversation
Replace `!=` in `(year % 400) != 0` (line 49) with `==` Justification: Years that are divisible by 100 (centurian == 100) but not by 400 (year % 400 != 0) are skipped and NOT leap year.
imSanko
suggested changes
Nov 25, 2024
Contributor
imSanko
left a comment
There was a problem hiding this comment.
Parenthesize a and b expressions when chaining and and or together, to make the precedence clear
Correct the parentheses to make clear the precedence of the conditional check
minh-swinburne
commented
Dec 30, 2024
Contributor
Author
minh-swinburne
left a comment
There was a problem hiding this comment.
I've changed the incorrect conditional operator and ensure clarity using parentheses
tianyizheng02
requested changes
Dec 30, 2024
Co-authored-by: Tianyi Zheng <tianyizheng02@gmail.com>
imSanko
approved these changes
Jan 18, 2025
tianyizheng02
approved these changes
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
!=in(year % 400) != 0(line 49) with==Justification: Years that are divisible by 100 (centurian == 100) but not by 400 (year % 400 != 0) are skipped and NOT leap year.
Describe your change:
Checklist: