Skip to content

Added doctest to decision_tree.py#11143

Merged
cclauss merged 6 commits intoTheAlgorithms:masterfrom
Suyashd999:patch-12
Nov 5, 2023
Merged

Added doctest to decision_tree.py#11143
cclauss merged 6 commits intoTheAlgorithms:masterfrom
Suyashd999:patch-12

Conversation

@Suyashd999
Copy link
Contributor

@Suyashd999 Suyashd999 commented Nov 5, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

cclauss
cclauss reviewed Nov 5, 2023
View reviewed changes
cclauss
cclauss reviewed Nov 5, 2023
View reviewed changes
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 5, 2023
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Nov 5, 2023
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 5, 2023
@cclauss cclauss enabled auto-merge (squash) November 5, 2023 09:15
cclauss
cclauss approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raise ValueErrors instead of print() as discussed in CONTRIBUTING.md.

@cclauss cclauss merged commit 257cfbd into TheAlgorithms:master Nov 5, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Nov 5, 2023
cclauss added a commit to cclauss/Python that referenced this pull request Jan 13, 2024
@Suyashd999 @cclauss
Added doctest to decision_tree.py (TheAlgorithms#11143)
d688108 
* Added doctest to decision_tree.py

* Update decision_tree.py

* Update machine_learning/decision_tree.py

* Update machine_learning/decision_tree.py

* raise ValueError()

* Update decision_tree.py

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Suyashd999 @cclauss