Data structures/arrays/triplet sum#11134
Merged
cclauss merged 11 commits intoTheAlgorithms:masterfrom Nov 6, 2023
Merged
Conversation
Signed-off-by: Skyad <777.sunnykumar@gmail.com>
Signed-off-by: Sunny Kumar <sunny.kumar09@ad.infosys.com>
Signed-off-by: Skyad <777.sunnykumar@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Skyad <777.sunnykumar@gmail.com>
…om/Skyad/Python into data_structures/arrays/triplet_sum
cclauss
reviewed
Nov 5, 2023
|
|
||
|
|
||
| def find_triplets_with_0_sum(nums: list[int]) -> list[list[int]]: | ||
| def find_triplets_with_0_sum(nums: list) -> list: |
Contributor
Author
There was a problem hiding this comment.
Since after updating the code in the existing file, "(nums: list[int]) -> list[list[int]]:" was failing in ruff test.
(ruff find_triplets_with_0_sum.py was throwing error so I changed to ( nums: list) -> list: )
cclauss
reviewed
Nov 5, 2023
Comment on lines
+47
to
+48
| Time complexity: O(N^2) | ||
| Auxiliary Space: O(N) |
Contributor
Author
There was a problem hiding this comment.
Time complexity: O(N^2)
--> This approach has two nested for loops, outer loop runs from start till end of the array length and inner loop from start+1 to end, that's why it has N^2 time complexity.
Auxiliary Space: O(N)
--> This method Creates a hashmap to store the elements so n extra space has been used.
cclauss
reviewed
Nov 5, 2023
| output_arr = [] | ||
|
|
||
| # Set the initial element as arr[i]. | ||
| for i in range(len(arr) - 2): |
Member
There was a problem hiding this comment.
Suggested change
| for i in range(len(arr) - 2): | |
| for i, item in enumerate(arr[:-2]): |
cclauss
reviewed
Nov 5, 2023
| current_sum = target_sum - arr[i] | ||
|
|
||
| # Traverse the subarray arr[i+1:]. | ||
| for j in range(i + 1, len(arr)): |
Member
There was a problem hiding this comment.
Suggested change
| for j in range(i + 1, len(arr)): | |
| for other_item in arr[i+1:]: |
cclauss
requested changes
Nov 5, 2023
Member
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
Let's not use less specific type hints.
algorithms-keeper
bot
added
the
awaiting changes
added 2 commits
November 6, 2023 15:44
…om/Skyad/Python into data_structures/arrays/triplet_sum
Signed-off-by: Sunny Kumar <sunny.kumar09@ad.infosys.com>
algorithms-keeper
bot
added
awaiting reviews
for more information, see https://pre-commit.ci
Signed-off-by: Skyad <777.sunnykumar@gmail.com>
cclauss
approved these changes
Nov 6, 2023
Member
cclauss
left a comment
cclauss
left a comment
There was a problem hiding this comment.
I put the more explicit type hints back in place.
algorithms-keeper
bot
removed
the
awaiting reviews
15 tasks
Contributor
Author
|
Thanks !! Christian Clauss for reviewing and accepting my code contribution. |
cclauss
added a commit
to cclauss/Python
that referenced
this pull request
Jan 13, 2024
* updated code for find triplets with 0 sum Signed-off-by: Skyad <777.sunnykumar@gmail.com> * extra line added at the end of file Signed-off-by: Sunny Kumar <sunny.kumar09@ad.infosys.com> * extra line added at the end of file Signed-off-by: Skyad <777.sunnykumar@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * file updated with comments Signed-off-by: Skyad <777.sunnykumar@gmail.com> * updated the comments as suggested by community Signed-off-by: Sunny Kumar <sunny.kumar09@ad.infosys.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * file updated according to community comments Signed-off-by: Skyad <777.sunnykumar@gmail.com> * Update find_triplets_with_0_sum.py --------- Signed-off-by: Skyad <777.sunnykumar@gmail.com> Signed-off-by: Sunny Kumar <sunny.kumar09@ad.infosys.com> Co-authored-by: Sunny Kumar <sunny.kumar09@ad.infosys.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This contribution includes the hashing approach for finding the triplet sum as 0.
Checklist: